Removal of the AppAction icon extension on Android

[moljac]

Description of Change

Context: Android will not render AppAction icons with provided filename (no error, no runtime crash), while other platforms support extensionless icon names.

Issues Fixed

Fixes #9234

Details: #9234 (comment)

[mattleibow]

Platform-specific changes really should be in the android file. Rather remove the extension when creating the native action as this behaviour is a bit unexpected here.

[moljac]

Platform-specific changes really should be in the android file. Rather remove the extension when creating the native action as this behaviour is a bit unexpected here.

these blocks were a bit confusing and misleading (with #preprocessor), so I thought it is OK to place code in *.shared.cs

https://github.com/dotnet/maui/blob/main/src/Essentials/src/AppActions/AppActions.shared.cs#L42-L69

https://github.com/dotnet/maui/blob/main/src/Essentials/src/AppActions/AppActions.shared.cs#L42-L69

[moljac]

OK. Code moved to AppActions.android.cs.

I hope it is better

[Redth]

@moljac you are missing a using System.IO; in the file.

Once that's fixed this should be good to go.

[jfversluis]

/azp run

[jfversluis]

Whoops looks like the build was actually fine but the CLA was still giving issues. Did we get anywhere with that @rmarinho ?

[mattleibow]

I see there is a change to the maui.aar without any java code changes. Can we revert that?

[rmarinho]

I still didn't got a response @jfversluis , seems close and reopen would work but it isn't

[moljac]

I still didn't got a response @jfversluis , seems close and reopen would work but it isn't

Resopnse from me?
Do I need to do something?

[jfversluis]

@moljac not from you! From people in charge of the CLA stuff :D but it seems closing and reopening did something because the CLA check is happy now.

Just the comment from Matt above needs addressing now!

[moljac]

Just the comment from Matt above needs addressing now!

why is this maui.aar commited? It is being changed on every local build.

I know - tooling. I bit confusing. Could it be added to .gitginore?