Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Allow to scroll horizontal WebView content inside TabbedPage #14320

Closed
wants to merge 42 commits into from
Closed

[Android] Allow to scroll horizontal WebView content inside TabbedPage #14320

wants to merge 42 commits into from

Conversation

jsuarezruiz
Copy link
Contributor

Description of Change

Allow to scroll horizontal WebView content inside TabbedPage

fix-6487

Issues Fixed

Fixes #6487

@ghost ghost added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Mar 31, 2023
mandel-macaque
mandel-macaque previously approved these changes Apr 3, 2023
View reviewed changes
Copy link
Member

@mandel-macaque mandel-macaque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with a small nit.

src/Core/src/Platform/Android/MauiWebView.cs Outdated Show resolved Hide resolved
@jsuarezruiz
Copy link
Contributor Author

@PureWeen Could I have your feedback with this one?. Thanks!

PureWeen
PureWeen previously requested changes Jun 8, 2023
View reviewed changes
Copy link
Member

@PureWeen PureWeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use the new Appium code we've added to write a UITest for this?

FYI @sbanni

@jsuarezruiz
Copy link
Contributor Author

Can you use the new Appium code we've added to write a UITest for this?

FYI @sbanni

Sure. Added.

@jsuarezruiz jsuarezruiz marked this pull request as draft June 27, 2023 15:03
@samhouts samhouts removed the request for review from PureWeen August 10, 2023 19:04
@jsuarezruiz jsuarezruiz requested a review from a team as a code owner August 18, 2023 06:45
@samhouts samhouts added the stale Indicates a stale issue/pr and will be closed soon label Sep 11, 2023
@jsuarezruiz jsuarezruiz removed the stale Indicates a stale issue/pr and will be closed soon label Oct 17, 2023
@PureWeen PureWeen dismissed their stale review October 19, 2023 13:24

Changes Made

@samhouts samhouts added the stale Indicates a stale issue/pr and will be closed soon label Dec 14, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Feb 18, 2024
@Eilon Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024
@samhouts samhouts removed this from the Under Consideration milestone Jul 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattleibow mattleibow Awaiting requested review from mattleibow mattleibow is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

@mandel-macaque mandel-macaque Awaiting requested review from mandel-macaque

@PureWeen PureWeen Awaiting requested review from PureWeen

Assignees
No one assigned
Labels
area-controls-webview WebView platform/android 🤖 stale Indicates a stale issue/pr and will be closed soon t/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WebView within TabbedPage on Android has weird scrolling interactions
6 participants
@jsuarezruiz @mandel-macaque @PureWeen @Eilon @samhouts @sbanni