Keyboard test fixes v2 #14397
Merged
Keyboard test fixes v2 #14397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
PureWeen
force-pushed
the
keyboard_test_fixes_v2
branch
2 times, most recently
from
3216fce
to
e67106d
Compare
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
PureWeen
commented
Apr 5, 2023
| { | ||
| // Because we retry on CI we don't want to delete the previous failures | ||
| // We want to publish those files for reference | ||
| DeleteFiles(Directory(TEST_RESULTS).Path.Combine("*.*").FullPath); |
There was a problem hiding this comment.
Is this ok @rmarinho? Will there be results left over from other CI runs that we need to clear out?
There was a problem hiding this comment.
Hum, the macos images are not clear, so in a next test run there could be files there?
I wonder if we just need a step to clear this on the yaml timeline when the pipeline starts
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
PureWeen
force-pushed
the
keyboard_test_fixes_v2
branch
from
16cc14d
to
99c1055
Compare
rachelkang
reviewed
Apr 6, 2023
rachelkang
reviewed
Apr 6, 2023
rachelkang
requested changes
Apr 6, 2023
rachelkang
reviewed
Apr 6, 2023
src/Controls/tests/DeviceTests/Elements/Application/ApplicationTests.Android.cs
Show resolved
Hide resolved
rachelkang
approved these changes
Apr 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
#14388 was merged a bit early. I should have left it as draft, we were still seeing occasional failures.