Make Benchmarks.Droid runnable as APK for perf testing #14447
Conversation
Setup env vars to be replaced and INLAB to always be one. Shift perflab dependencies to the app build (Runtime) through insertion rather than being in the Maui repo.
ghost
added
the
|
Hey there @LoopedBard3! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
| <!-- HACK: to workaround System.IO.FileNotFoundException: /System.Private.CoreLib.dll --> | ||
| <EmbedAssembliesIntoApk>false</EmbedAssembliesIntoApk> |
There was a problem hiding this comment.
I had to use a nightly BenchmarkDotNet to remove this change:
jonathanpeppers/BenchmarkDotNet-Android@2a05887
Did 0.13.5 work for you somehow?
We need this fix to be in the release on NuGet.org: dotnet/BenchmarkDotNet@2cce425
There was a problem hiding this comment.
Hmm.. would adding the BDN prerelease feed that my team manages to the Nuget.Config file work?
<add key="benchmark-dotnet-prerelease" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/benchmark-dotnet-prerelease/nuget/v3/index.json" />.
I would also update the version specified to match the one we have there (0.13.5.2136). This is also assuming that adding the nightly feed would not be doable.
There was a problem hiding this comment.
We can add a dnceng feed, but probably not one like <add key="bdn-ci" value="https://ci.appveyor.com/nuget/benchmarkdotnet" />.
| System.Environment.SetEnvironmentVariable("PERFLAB_INLAB", "1"); | ||
| System.Environment.SetEnvironmentVariable("PERFLAB_BUILDTIMESTAMP", "0001-01-01T00:00:00.0000000Z"); | ||
| System.Environment.SetEnvironmentVariable("PERFLAB_BUILDNUM", "REPLACE_BUILDNUM"); | ||
| System.Environment.SetEnvironmentVariable("DOTNET_VERSION", "REPLACE_DOTNET_VERSION"); | ||
| System.Environment.SetEnvironmentVariable("PERFLAB_HASH", "REPLACE_HASH"); | ||
| System.Environment.SetEnvironmentVariable("HELIX_CORRELATION_ID", "REPLACE_HELIX_CORRELATION_ID"); | ||
| System.Environment.SetEnvironmentVariable("PERFLAB_PERFHASH", "REPLACE_PERFLAB_PERFHASH"); | ||
| System.Environment.SetEnvironmentVariable("PERFLAB_RUNNAME", "REPLACE_PERFLAB_RUNNAME"); | ||
| System.Environment.SetEnvironmentVariable("HELIX_WORKITEM_FRIENDLYNAME", "REPLACE_HELIX_WORKITEM_FRIENDLYNAME"); | ||
| System.Environment.SetEnvironmentVariable("PERFLAB_REPO", "REPLACE_PERFLAB_REPO"); | ||
| System.Environment.SetEnvironmentVariable("PERFLAB_BRANCH", "REPLACE_PERFLAB_BRANCH"); | ||
| System.Environment.SetEnvironmentVariable("PERFLAB_QUEUE", "REPLACE_PERFLAB_QUEUE"); | ||
| System.Environment.SetEnvironmentVariable("PERFLAB_BUILDARCH", "REPLACE_PERFLAB_BUILDARCH"); | ||
| System.Environment.SetEnvironmentVariable("PERFLAB_LOCALE", "REPLACE_PERFLAB_LOCALE"); |
There was a problem hiding this comment.
I think implicit usings are enabled in this project:
Do you need to put System. on all of these?
There was a problem hiding this comment.
Could we also condition all these behind a #if PERFLAB? And then you can set $(DefineConstants) as needed from your pipeline?
There was a problem hiding this comment.
I will get a test with these changes going.
…LAB constant being defined.
|
Thank you for your pull request. We are auto-formatting your source code to follow our code guidelines. |
… Add the Dotnet Perf Team private BDN prerelease feed to the nuget.config and update the BDN reference for the app to be the latest in the prerelease feed.
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
…n the code we inject.
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Eilon
added
the
t/perf
Description of Change
Sets up the Benchmarks.Droid test app for testing as an APK in the performance lab. This change is being done in conjunction with work to get Android BenchmarkDotnet runs working: https://github.com/dotnet/performance/pull/2955/files