Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Do not rebuild the ms tasks on device tests. #14476

Merged
merged 3 commits into from
May 10, 2023
Merged

[CI] Do not rebuild the ms tasks on device tests. #14476

merged 3 commits into from
May 10, 2023

Conversation

mandel-macaque
Copy link
Member

We do not want to rebuild the tasks but use the workloads to run the device tests. The reasons for this tests are:

  1. We should be testing what we ship, not a diff build.
  2. We cna emsure that the megapipeline will be testing with the bumped android and iOS sdks.

@mandel-macaque
[CI] Do not rebuild the ms tasks on device tests.
80bf548 
We do not want to rebuild the tasks but use the workloads to run the
device tests. The reasons for this tests are:

1. We should be testing what we ship, not a diff build.
2. We cna emsure that the megapipeline will be testing with the bumped
   android and iOS sdks.
@mandel-macaque
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@rmarinho
Copy link
Member 

eng/pipelines/common/device-tests-steps.yml (Line: 30, Col: 5): Unexpected value 'if False'
/eng/pipelines/common/device-tests-steps.yml (Line: 50, Col: 5): The expression directive 'else' is not supported in this context
/eng/pipelines/common/device-tests-steps.yml (Line: 50, Col: 5): Unexpected value '${{ else }}'

@Eilon Eilon added the area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions label Apr 10, 2023
@mandel-macaque mandel-macaque marked this pull request as ready for review April 10, 2023 20:51
@rmarinho
Copy link
Member

@mandel-macaque do we have a link for usage of useArtifacts true ?

@mandel-macaque
Copy link
Member Author

@rmarinho will build a sample for the unified pipeline and post it here

@mattleibow
Copy link
Member

This appears to be building by default still? Is this correct?

@PureWeen PureWeen merged commit f0dbcab into main May 10, 2023
@PureWeen PureWeen deleted the dev/mandel/install-workload-device-tests branch May 10, 2023 15:38
rmarinho pushed a commit that referenced this pull request May 30, 2023
@mandel-macaque @rmarinho
[CI] Do not rebuild the ms tasks on device tests. (#14476)
575b6b7 
* [CI] Do not rebuild the ms tasks on device tests.

We do not want to rebuild the tasks but use the workloads to run the
device tests. The reasons for this tests are:

1. We should be testing what we ship, not a diff build.
2. We cna emsure that the megapipeline will be testing with the bumped
   android and iOS sdks.

* Allow to rebuild the tasks which is what is expected in the maui repo.

* Use the correct template.
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattleibow mattleibow mattleibow approved these changes

@jsuarezruiz jsuarezruiz jsuarezruiz approved these changes

Assignees
No one assigned
Labels
area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mandel-macaque @rmarinho @mattleibow @jsuarezruiz @Eilon @PureWeen