Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue using FillRule with Paths #14493

Merged
merged 10 commits into from
Apr 20, 2023
Merged

Fix issue using FillRule with Paths #14493

merged 10 commits into from
Apr 20, 2023

Conversation

jsuarezruiz
Copy link
Contributor

@jsuarezruiz jsuarezruiz commented Apr 10, 2023 •
edited by samhouts

Description of Change

Fix issue using the FillRule property with Paths.

Before
image

After
image

To test the changes, launch the .NET MAUI Gallery and navigate to the Path samples. Then, check the composite shape result.
image

Issues Fixed

Fixes #14461
Fixes #15431

@jsuarezruiz jsuarezruiz added t/bug Something isn't working platform/windows 🪟 platform/android 🤖 area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing platform/iOS 🍎 labels Apr 10, 2023
@rachelkang
Copy link
Member

Note for reviewers: the sample is located at Controls > Shapes > More samples > Path Gallery

rachelkang
rachelkang requested changes Apr 12, 2023
View reviewed changes
Copy link
Member

@rachelkang rachelkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, as described, on Windows and Android, but unfortunately not on iOS. The Composite shape, overlapping rectangles, and multiple line segments shapes are all completely filled/solid with no negative spaces.

image

@jsuarezruiz
Copy link
Contributor Author

Looks great, as described, on Windows and Android, but unfortunately not on iOS. The Composite shape, overlapping rectangles, and multiple line segments shapes are all completely filled/solid with no negative spaces.

image

Fixed. Could you try again?
Captura de pantalla 2023-04-14 a las 12 02 10

rachelkang
rachelkang requested changes Apr 18, 2023
View reviewed changes
Copy link
Member

@rachelkang rachelkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iOS rendering LGTM too now! Just a couple small comments

src/Controls/src/Core/Platform/ShapeExtensions.cs Show resolved Hide resolved
src/Controls/src/Core/Platform/iOS/ShapeViewExtensions.cs Outdated Show resolved Hide resolved
src/Controls/src/Core/Platform/Windows/ShapesExtensions.cs Outdated Show resolved Hide resolved
@rachelkang rachelkang merged commit 660784f into main Apr 20, 2023
29 checks passed
@rachelkang rachelkang deleted the fix-14461 branch April 20, 2023 14:15
@jsuarezruiz jsuarezruiz mentioned this pull request Jun 5, 2023
Closed
@jsuarezruiz jsuarezruiz added the backport/suggested The PR author or issue review has suggested that the change should be backported. label Jun 5, 2023
@hartez hartez added the backport/NO This change should not be backported. It may break customers. label Jun 7, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rachelkang rachelkang rachelkang approved these changes

@mandel-macaque mandel-macaque Awaiting requested review from mandel-macaque

Assignees
No one assigned
Labels
area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing backport/NO This change should not be backported. It may break customers. backport/suggested The PR author or issue review has suggested that the change should be backported. platform/android 🤖 platform/iOS 🍎 platform/windows 🪟 t/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The EvenOdd FillRule failed in the wraping space FillRule.EvenOdd not working for shapes
3 participants
@jsuarezruiz @rachelkang @hartez