Added ICommandMapper for extension methods #14545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattleibow
commented
Apr 12, 2023
This comment was marked as outdated.
This comment was marked as outdated.
# Conflicts: # src/Core/src/PublicAPI/net-android/PublicAPI.Unshipped.txt
mattleibow
commented
Apr 14, 2023
23 tasks
PureWeen
approved these changes
Apr 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR adds in the matching
ICommandMapperand some extension methods that allow for customization of the mappers without having to replace them as this causes issues in AOT.The fix for the AOT and the switch to use these changes are in #13836
Issues Fixed
Fixes #2204