Commits on Apr 17, 2023

1. [graphics] fix CA1307 and CA1309 for performance …

   Context: dotnet#12130
   Context: https://github.com/angelru/CvSlowJittering
   
   While reviewing the above sample, I saw time spent doing culture-aware
   string "stuff" in Microsoft.Maui.Graphics:
   
       77.22ms microsoft.maui!Microsoft.Maui.Graphics.MauiDrawable.SetDefaultBackgroundColor()
       42.55ms System.Private.CoreLib!System.String.ToLower()
   
   In c40c6e7, I added code analysis rules to the `.editorconfig`, but
   it appears we ignored these warnings in dbaeee9.
   
   These are generally easy to fix, we should have just addressed these
   instead of adding `$(NoWarn)`.
   
   In the future, I will look into adding `CA1311`:
   
   https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1311
   
   This would find `string.ToLower()` calls and recommend
   `string.ToLowerInvariant()` instead. I fixed the one place I saw it
   affecting performance in `dotnet-trace`.

   

   jonathanpeppers committed Apr 17, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 0af580a
   • Browse repository at this point

   Copy the full SHA

   0af580a View commit details

   Browse the repository at this point in the history