Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a new Microsoft.NET.Sdk.Maui .NET SDK #14640

Closed
wants to merge 1 commit into from
Closed

Conversation

mattleibow
Copy link
Member

@mattleibow mattleibow commented Apr 18, 2023

Description of Change

This allows for some more complex operations where we can have the project SDK and use NuGet packages without needing to have the .NET MAUI workload installed.

I have a test here: https://github.com/mattleibow/Microsoft.NET.Sdk.Maui

This change is optional but will allow for a project to look like this if the workload is NOT installed:

<Project Sdk="Microsoft.NET.Sdk.Maui/8.0.0">
    <!-- no need for UseMaui -->
</Project>

One downside is that may be a blocking action as the SDK will have to download or validate the package is downloaded on each evaluation. I will need to verify this.

However, if the workload IS installed, then we do not get any additional cost and the workload behaves like all the others - and we can leave off the version number:

<Project Sdk="Microsoft.NET.Sdk.Maui">
    <!-- no need for UseMaui -->
</Project>

Tasks

  • Create normal SDK Microsoft.NET.Sdk.Maui
  • Create Blazor/Razor SDK Microsoft.NET.Sdk.Maui.Razor

Comment on lines +142 to +150
"Microsoft.NET.Sdk.Maui": {
"kind": "sdk",
"version": "@VERSION@"
},
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the magic that makes things work - no version here as we are using the workload version.

@Eilon Eilon added the area-setup Installation, setup, requirements, maui-check, workloads, platform support label Jun 20, 2023
@mattleibow mattleibow closed this Jun 20, 2023
@mattleibow mattleibow reopened this Nov 2, 2023
@mattleibow mattleibow force-pushed the dev/new-sdk branch 2 times, most recently from 54e7601 to 8e36002 Compare November 2, 2023 17:12
@mattleibow mattleibow changed the title Try a new Microsoft.NET.Sdk.Maui SDK Create a new Microsoft.NET.Sdk.Maui SDK Nov 3, 2023
@mattleibow mattleibow changed the title Create a new Microsoft.NET.Sdk.Maui SDK Create a new Microsoft.NET.Sdk.Maui .NET SDK Nov 3, 2023
@samhouts samhouts added the stale Indicates a stale issue/pr and will be closed soon label Nov 21, 2023
@mattleibow
Copy link
Member Author

Closing this for now. The better fixes are to make sure the various platforms work better with NuGet packages - mostly WinUI is causing trouble.

@mattleibow mattleibow closed this May 20, 2024
@mattleibow mattleibow deleted the dev/new-sdk branch May 20, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-setup Installation, setup, requirements, maui-check, workloads, platform support stale Indicates a stale issue/pr and will be closed soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants