Remove Controls Navigation Controller #14976
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This class currently isn't used anywhere so its existence is confusing. It was incorrectly referenced inside the controls mappers. The
NavigationViewHandler
on iOS was never completed, the code was left there with the good intention of being completed but alas there has not been time for that yet. So, for now, we should just delete this code to reduce confusion.NavigationViewHandler
so if it's accidentally used the user is directed to the correct handler. I've ran into this a number of times writing tests where I'll map the wrong handler.NavigationRenderer
largetitles
andtransluscent