Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PrependToMapping method to replace Window MapTitle method #15041

Merged
merged 5 commits into from May 23, 2023

Conversation

mattleibow
Copy link
Member

@mattleibow mattleibow commented May 11, 2023

Description of Change

This PR makes the Window Title mapper use new methods instead of calling "base" mappers.

Part of the fix for #11662 and part of PR #13836

@mattleibow mattleibow requested a review from PureWeen May 11, 2023 19:53
@mattleibow mattleibow changed the title Use new PrependToMapping method Use ReplaceMapping method to replace Window MapTitle method May 12, 2023
@mattleibow mattleibow changed the title Use ReplaceMapping method to replace Window MapTitle method Use PrependToMapping method to replace Window MapTitle method May 16, 2023
@mattleibow mattleibow requested a review from PureWeen May 16, 2023 06:10
@PureWeen PureWeen merged commit c7cc10b into main May 23, 2023
29 checks passed
@PureWeen PureWeen deleted the dev/window-title branch May 23, 2023 22:12
rmarinho pushed a commit that referenced this pull request May 30, 2023
* Use new PrependToMapping method

* this

* The entire method is replaced

* Added a test
@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants