Tests and fixes to verify that spanned views are including spacing in measurements #15119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… their measurements
hartez
commented
May 16, 2023
|
Thank you for your pull request. We are auto-formatting your source code to follow our code guidelines. |
Eilon
added
the
area/layout
mattleibow
approved these changes
May 19, 2023
mattleibow
approved these changes
May 19, 2023
rmarinho
approved these changes
May 19, 2023
rmarinho
pushed a commit
that referenced
this pull request
May 30, 2023
… measurements (#15119) * Tests and fixes to verify that spanned views are including spacing in their measurements * Update src/Core/src/Layouts/GridLayoutManager.cs * Auto-format source code * Update GridLayoutManagerTests.cs --------- Co-authored-by: GitHub Actions Autoformatter <autoformat@example.com> Co-authored-by: Matthew Leibowitz <mattleibow@live.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Views which span Grid columns/rows aren't taking the spacing of the rows into account during measurement.
They're accounting for the spacing during layout, but since the measurement step isn't always utilizing the spacing, some controls are getting shorted on their initial measurements for sizing. This change fixes that, and adds tests to catch this situation in the future.
Issues Fixed
Ensures that Grid child views are getting their full measurement constraints when they span multiple columns/rows.