Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UITest Gallery and some simple tests #15191

Merged
merged 9 commits into from
May 30, 2023
Merged

Add UITest Gallery and some simple tests #15191

merged 9 commits into from
May 30, 2023

Conversation

sbanni
Copy link
Contributor

@sbanni sbanni commented May 19, 2023

Description of Change

Initial UI test gallery with additional API support for certain actions in Appium.
Also starting the work to abstract out the Appium layer to make it easier to replace in the future if that is the direction we go.

below is it running a few of the tests that are included in this PR for Windows and Android
GIF 5-19-2023 12-56-57 PM

@sbanni sbanni requested review from rmarinho and PureWeen May 19, 2023 20:00
@github-actions
Copy link
Contributor

Thank you for your pull request. We are auto-formatting your source code to follow our code guidelines.

@Eilon Eilon added the area-testing Unit tests, device tests label May 22, 2023

namespace TestUtils.Appium.UITests
{
public interface IApp2 : IApp, IDisposable
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to ingest the actual Xamarin.UITest IApp here? Can we just copy the IApp implementation and remove the Xamarin.UItest dependency?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's more stuff like AppResult and everything we would need to copy more stuff over.

Copy link
Member

@PureWeen PureWeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to add the

"src\TestUtils\src\Microsoft.Maui.IntegrationTests\Microsoft.Maui.IntegrationTests.csproj",

to the "-Mac.slnf" file

@github-actions
Copy link
Contributor

Thank you for your pull request. We are auto-formatting your source code to follow our code guidelines.

@PureWeen PureWeen self-requested a review May 25, 2023 02:23
@github-actions
Copy link
Contributor

Thank you for your pull request. We are auto-formatting your source code to follow our code guidelines.

@rmarinho rmarinho enabled auto-merge (squash) May 30, 2023 10:53
@rmarinho rmarinho disabled auto-merge May 30, 2023 23:54
@rmarinho rmarinho merged commit 75347d5 into main May 30, 2023
29 checks passed
@rmarinho rmarinho deleted the dev/scoban/uigallery branch May 30, 2023 23:55
@NickDarvey NickDarvey mentioned this pull request Jun 6, 2023
3 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-testing Unit tests, device tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants