Set Version for Windows

[mattleibow]

Description of Change

This PR fixes an issue where setting <ApplicationDisplayVersion> to anything other than 1.0 caused the IDE to fail to restore NuGets. There was a fix before #6628 however, it appears this was before another fix landed which effectively disabled the change until after the NuGet restore completed: #6767

As a result, the fix was "lost". This PR moves the fix out of the NuGet (where it is too late) and directly into the workload.

Issues Fixed

• Fixes Dotnet restore fails when ApplicationDisplayVersion has some values to configure Unit Test for MAUI #12859
• Fixes Compiling as DLL with ApplicationDisplayVersion higher than 1.0 fails #10579
• Related [BUG] Error NETSDK1005 after changes in .csproj file #6626

Workaround

For now the easiest workaround is to add <Version>$(ApplicationVersion)</Version> in your project directly after your <ApplicationVersion>1.0</ApplicationVersion> property.

[mattleibow]

Backported to #15240

[jonathanpeppers]

This used to be in WinUI targets:

• https://github.com/dotnet/maui/blob/net7.0/src/Workload/Microsoft.Maui.Sdk/Sdk/WinUI.targets

But I guess that won't work, because this would only work after a restore now:

• https://github.com/dotnet/maui/blob/main/src/Core/src/nuget/buildTransitive/WinUI.targets

There are 2 things different with this change than before:

• This is in a *.Before.targets and it used to be *.After.targets. Is the ordering right?
• The condition is a little different than what imported WinUI.targets:

maui/src/Workload/Microsoft.Maui.Sdk/Sdk/Microsoft.Maui.Core.Sdk.After.targets

Line 14 in 8b8293f

<Import Project="WinUI.targets" Condition=" '$(TargetPlatformIdentifier)' == 'windows' and '$(WindowsAppSDKWinUI)' == 'true'" />

If this was moved to some *.After.targets would be be able to use the same Condition as before? $(TargetPlatformIdentifier) is probably blank at the point you have this.

[mattleibow]

I think using GetTargetPlatformIdentifier is the most correct way. I believe? Order does not really matter as it all comes after the workload targets - and ios/android seems to be in this spot.

'$(WindowsAppSDKWinUI)' == 'true' This is the real issue actually. when you did a PR back in the day, this was not there. I added it at some point and it broke. So now I am moving this out - and to be consistent with android and ios I am using the Before spot - which is a bad name really - it is just immediate. No idea why it is "before"...

[jonathanpeppers]

Looking at a .binlog from Essentials.DeviceTests.csproj [net7.0-windows10.0.19041] on this PR:

This looks like it matches the net7.0-android build now.

[rmarinho]

/rebase