Improved WebUtils.ParseQueryString() #15245
Conversation
| @@ -1,45 +1,50 @@ | |||
| using System; | |||
| using System.Collections.Generic; | |||
| using System.Diagnostics; | |||
| using System.Linq; | |||
| using System.Text; | |||
|
|
|||
| namespace Microsoft.Maui.ApplicationModel | |||
| { | |||
| static class WebUtils | |||
| { | |||
| internal static IDictionary<string, string> ParseQueryString(string url) | |||
There was a problem hiding this comment.
Is there some standard System.Uri parsing code we can call instead of writing our own?
It seems like there should be a BCL way to return a dictionary of key/value pairs.
There was a problem hiding this comment.
It does seem like there should be a class for this in the BCL but afaik, there isn't.
It is definitely not part of Uri.
There was a problem hiding this comment.
This is the new one:
Can we bring in the source for it and make it internal?
https://source.dot.net/#Microsoft.AspNetCore.WebUtilities/QueryHelpers.cs,1c1b023fbf834a3d
jstedfast
force-pushed
the
dev/jestedfa/webauthenticatorresults-decode-hex
branch
from
836612c
to
34de1eb
Compare
|
Thank you for your pull request. We are auto-formatting your source code to follow our code guidelines. |
jstedfast
force-pushed
the
dev/jestedfa/webauthenticatorresults-decode-hex
branch
3 times, most recently
from
8648d2f
to
67cba8b
Compare
Eilon
added
the
area/essentials
jstedfast
force-pushed
the
dev/jestedfa/webauthenticatorresults-decode-hex
branch
from
67cba8b
to
f7cc37c
Compare
|
Thank you for your pull request. We are auto-formatting your source code to follow our code guidelines. |
| var span = query.AsSpan(valueIndex, index - valueIndex); | ||
| var chars = new char[span.Length]; |
There was a problem hiding this comment.
I like how we got optimized Span<T> code now for free!
* Reduce memory allocations * Decode parameter values Fixes issue #9223
jstedfast
force-pushed
the
dev/jestedfa/webauthenticatorresults-decode-hex
branch
from
1cb675e
to
edeae34
Compare
|
Thank you for your pull request. We are auto-formatting your source code to follow our code guidelines. |
|
@jonathanpeppers looks like the failure is due to an old version of Xcode. What do we do to progress on this? |
|
Someone on the MAUI team can check? Maybe @rmarinho? @mattleibow I think you should review, too -- this is something in Essentials. |
|
it's not related we can move this and ignore that failure. We are still looking on a fix. |
Description of Change
Issues Fixed
Fixes issue #9223