Various fixes for Border on Android #15458
Conversation
|
Unfortunately this isn't enough to fix the issue :-( There seems to be more problems influencing this bug. From what I can tell, something to do with Grid layout (due to star dimensions), but I can't figure that part out without a working debugger. Being stuck with only CWL's makes this incredibly painful. |
Eilon
added
the
area/drawing ✏️
|
Just an updated comment: I no longer think it has to do with |
jstedfast
force-pushed
the
dev/jestedfa/grid-border-strokethickness-inset
branch
4 times, most recently
from
c3c2da6
to
f855faf
Compare
jstedfast
changed the title
|
Okay, so I think that assuming the unit test passes, this bug is now fixed. The tests verified locally as well as with using the following XAML in the Sandbox app: diff --git a/src/Controls/samples/Controls.Sample.Sandbox/MainPage.xaml b/src/Controls/samples/Controls.Sample.Sandbox/MainPage.xaml
index e1762ab92..f2aff04df 100644
--- a/src/Controls/samples/Controls.Sample.Sandbox/MainPage.xaml
+++ b/src/Controls/samples/Controls.Sample.Sandbox/MainPage.xaml
@@ -3,4 +3,12 @@
xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml"
x:Class="Maui.Controls.Sample.MainPage"
xmlns:local="clr-namespace:Maui.Controls.Sample">
+
+ <Grid ColumnDefinitions="180,180" RowDefinitions="360,360" RowSpacing="0" ColumnSpacing="0">
+ <Border Grid.Row="0" Grid.Column="0" Background="Red" Stroke="Black" StrokeThickness="10" />
+ <Border Grid.Row="0" Grid.Column="1" Background="Orange" Stroke="Black" StrokeThickness="10" />
+ <Border Grid.Row="1" Grid.Column="0" Background="Green" Stroke="Black" StrokeThickness="10" />
+ <Border Grid.Row="1" Grid.Column="1" Background="Blue" Stroke="Black" StrokeThickness="10" />
+ </Grid>
+
</ContentPage>
\ No newline at end of file |
jstedfast
force-pushed
the
dev/jestedfa/grid-border-strokethickness-inset
branch
4 times, most recently
from
fd98eaf
to
8af1f15
Compare
* Fixed Border.CrossPlatformArrange() logic * Fixed Android's ShapeExtensions.ToPlatform() to not inset the path bounds *unless* innerPath is true. This is an attempt at fixing issue #15339
jstedfast
force-pushed
the
dev/jestedfa/grid-border-strokethickness-inset
branch
from
f33b663
to
a33b76f
Compare
| @@ -251,8 +251,8 @@ StrokeLineJoin switch | |||
|
|
|||
| public Size CrossPlatformArrange(Graphics.Rect bounds) | |||
There was a problem hiding this comment.
Could you document CrossPlatformArrange? Other than that looks good!
|
@jstedfast Should #15339 be closed now? |
|
This seems to have broken several layouts on Windows when stroke thickness is set to larger values (5). Was this PR even tested on Windows? |
|
@daltzctr This couldn't have broken Windows because all of the changes were in Android-specific source files. |
Description of Change
bounds unless innerPath is true.
Issues Fixed
This is an attempt at fixing issue #15339