Skip tests currently having issues on WinUI #15527

PureWeen · 2023-06-08T15:12:43Z

Description of Change

Anything in this PR that I marked Failing was failing on the original PR
I've marked one set of CV tests as a regression because those are windows only tests and they are failing so something here needs to be fixed.

The tests still have an issue running from end to end with completeness, because of an issue that gets hit with TitleBar after opening too many windows.

PureWeen · 2023-06-08T15:16:09Z

src/Controls/tests/DeviceTests/Elements/CheckBox/CheckBoxTests.cs

-		[Theory("Checkbox Background Updates Correctly With BackgroundColor Property")]
+		[Theory("Checkbox Background Updates Correctly With BackgroundColor Property",
+#if WINDOWS
+			Skip = "REVIEW FOR .NET8"


Broken in .NET7

PureWeen · 2023-06-08T16:15:59Z

src/Controls/tests/DeviceTests/Elements/CheckBox/CheckBoxTests.cs

-		[Theory("Checkbox Background Updates Correctly With BackgroundColor Property")]
+		[Theory("Checkbox Background Updates Correctly With BackgroundColor Property",
+#if WINDOWS
+			Skip = "Failing"


this was also failing in .NET7

PureWeen · 2023-06-08T16:17:34Z

src/Controls/tests/DeviceTests/Elements/CollectionView/CollectionViewTests.Windows.cs

@@ -54,7 +54,7 @@ public async Task CollectionViewHandlerDisconnects()
 			});
 		}

-		[Fact]
+		[Fact(Skip = "FIX FOR .NET8")]


PureWeen · 2023-06-08T16:17:39Z

src/Controls/tests/DeviceTests/Elements/CollectionView/CollectionViewTests.Windows.cs

@@ -101,7 +101,7 @@ void ValidateItemContainerStyle(CollectionView collectionView)
 			Assert.Equal(0d, minHeight);
 		}

-		[Fact]
+		[Fact(Skip = "FIX FOR .NET8")]


PureWeen · 2023-06-08T16:22:13Z

src/Controls/tests/DeviceTests/Elements/Shell/ShellTests.cs

-		[Fact(DisplayName = "Pages Do Not Leak")]
+		[Fact(DisplayName = "Pages Do Not Leak",
+#if WINDOWS
+			Skip = "Failing"


PureWeen · 2023-06-08T16:22:25Z

src/Controls/tests/DeviceTests/Elements/NavigationPage/NavigationPageTests.cs

-		[Fact(DisplayName = "Can Reuse Pages")]
+		[Fact(DisplayName = "Can Reuse Pages",
+#if WINDOWS
+			Skip = "Failing"


PureWeen · 2023-06-08T16:22:29Z

src/Controls/tests/DeviceTests/Elements/NavigationPage/NavigationPageTests.cs

-		[Fact(DisplayName = "NavigationPage Does Not Leak")]
+		[Fact(DisplayName = "NavigationPage Does Not Leak"
+#if WINDOWS
+			,Skip = "Failing"


PureWeen · 2023-06-08T16:22:34Z

src/Controls/tests/DeviceTests/Elements/ListView/ListViewTests.cs

-		[Fact]
+		[Fact
+#if WINDOWS
+			(Skip = "Failing")


PureWeen · 2023-06-08T16:22:39Z

src/Controls/tests/DeviceTests/Elements/Frame/FrameHandlerTest.Windows.cs

+
+namespace Microsoft.Maui.DeviceTests
+{
+	public partial class FrameHandlerTest


PureWeen · 2023-06-08T16:22:46Z

src/Controls/tests/DeviceTests/Elements/CollectionView/CollectionViewTests.cs

-			var layoutOptions = new LayoutOptions[] { LayoutOptions.Center, LayoutOptions.Start, LayoutOptions.End, LayoutOptions.Fill };
+			var layoutOptions = new LayoutOptions[] {
+
+#if !WINDOWS


* Update Win2D (#15400) Fixes #9104 * Fix broken button when adding PGR implicitly (#15419) * Fix broken button when adding PGR implicitly * - fix conditional * Bump Xamarin.GooglePlayServices.Maps from 118.1.0.1 to 118.1.0.2 (#15409) Bumps [Xamarin.GooglePlayServices.Maps](https://github.com/xamarin/GooglePlayServicesComponents) from 118.1.0.1 to 118.1.0.2. - [Release notes](https://github.com/xamarin/GooglePlayServicesComponents/releases) - [Commits](https://github.com/xamarin/GooglePlayServicesComponents/commits) --- updated-dependencies: - dependency-name: Xamarin.GooglePlayServices.Maps dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Correct docs for Grid ColumnSpacing/RowSpacing (#15425) * Bump Xamarin.Firebase.AppIndexing from 120.0.0.11 to 120.0.0.12 (#15406) Bumps [Xamarin.Firebase.AppIndexing](https://github.com/xamarin/GooglePlayServicesComponents) from 120.0.0.11 to 120.0.0.12. - [Release notes](https://github.com/xamarin/GooglePlayServicesComponents/releases) - [Commits](https://github.com/xamarin/GooglePlayServicesComponents/commits) --- updated-dependencies: - dependency-name: Xamarin.Firebase.AppIndexing dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Modify generated ID starting point to prevent collision with ItemViewType (#15438) * Move Windows and iOS Frame measure and arrange to xplat layer (#14987) * Fix Windows frame not resizing with screen Fixes #13552 * Make iOS Frame renderer us shared implementation Moving some frame border calculations to the xplat layer with more shared code * Add test * Auto-format source code * Remove padding update Windows was double counting padding * Fix test for other platforms * Auto-format source code * Fix typo * Add padding test --------- Co-authored-by: GitHub Actions Autoformatter <autoformat@example.com> * Bump Microsoft.NET.Test.Sdk from 17.6.0 to 17.6.1 (#15408) Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 17.6.0 to 17.6.1. - [Release notes](https://github.com/microsoft/vstest/releases) - [Changelog](https://github.com/microsoft/vstest/blob/main/docs/releases.md) - [Commits](microsoft/vstest@v17.6.0...v17.6.1) --- updated-dependencies: - dependency-name: Microsoft.NET.Test.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Pin main branch to net7 (#15452) * [uitests] Fix appium versions (#15453) * Upload appium * Pin all versions * Use variables * Prep better the script * Update dependencies from https://github.com/dotnet/xharness build 20230529.1 (#15450) Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit From Version 8.0.0-prerelease.23272.1 -> To Version 8.0.0-prerelease.23279.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * [net8.0] Don't pin sdk on net8 branch * Add the drag and drop gestures back to the appium ui tests for mac/ios targets * Update ModalNavigationManager.cs (#15483) * Don't reset App.Current OnResume if it's already set (#15496) * First pass at adding developer layout docs (#15426) * First pass at adding developer layout docs * Update docs/design/layout.md Co-authored-by: MartyIX <203266+MartyIX@users.noreply.github.com> --------- Co-authored-by: MartyIX <203266+MartyIX@users.noreply.github.com> * Clear window from ContextStub after it's closed (#15495) * Remove legacy launch settings (#15511) * Skip tests currently having issues on WinUI (#15527) * Skip tests currently having issues * Update AssertionExtensions.Windows.cs * - Update skip notes * - update notes * - update test notes * - update tests that have always been failing * - update test notes * - fix compile errors * Fix incorrect calculation of expansion size when *s have different scalars (#15532) Fixes #15494 * Change the tokens to null (#15560) Co-authored-by: tj-devel709 <tjlambert@microsoft.com> * Add all platforms if build args don't restrict to a single platform (#15561) * Restore & obsolete Windows MauiWebView ctor (#15541) * Restore & obsolete Windows MauiWebView ctor * Reinstate functionality for obsoleted ctor * Ignore additional tests for iOS (#15513) * Bump Microsoft.NET.Test.Sdk from 17.6.1 to 17.6.2 (#15502) Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 17.6.1 to 17.6.2. - [Release notes](https://github.com/microsoft/vstest/releases) - [Changelog](https://github.com/microsoft/vstest/blob/main/docs/releases.md) - [Commits](microsoft/vstest@v17.6.1...v17.6.2) --- updated-dependencies: - dependency-name: Microsoft.NET.Test.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/xharness build 20230607.1 (#15581) Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit From Version 8.0.0-prerelease.23279.1 -> To Version 8.0.0-prerelease.23307.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update Versions.props --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Matthew Leibowitz <mattleibow@live.com> Co-authored-by: Shane Neuville <shneuvil@microsoft.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: E.Z. Hart <hartez@users.noreply.github.com> Co-authored-by: Michael Cao <poppop208@gmail.com> Co-authored-by: Juan Diego Herrera <juherrera@microsoft.com> Co-authored-by: GitHub Actions Autoformatter <autoformat@example.com> Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Scott Banning <scoban@microsoft.com> Co-authored-by: MartyIX <203266+MartyIX@users.noreply.github.com> Co-authored-by: scoban <sbanni@users.noreply.github.com> Co-authored-by: TJ Lambert <50846373+tj-devel709@users.noreply.github.com> Co-authored-by: tj-devel709 <tjlambert@microsoft.com> Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com>

* Skip tests currently having issues * Update AssertionExtensions.Windows.cs * - Update skip notes * - update notes * - update test notes * - update tests that have always been failing * - update test notes * - fix compile errors

Skip tests currently having issues

0ea77ad

PureWeen commented Jun 8, 2023

View reviewed changes

PureWeen and others added 6 commits June 8, 2023 10:21

Update AssertionExtensions.Windows.cs

5d59f25

- Update skip notes

b4776aa

- update notes

f4e0c86

- update test notes

5f6d1d0

- update tests that have always been failing

d9ae542

- update test notes

bac406d

PureWeen commented Jun 8, 2023

View reviewed changes

PureWeen mentioned this pull request Jun 8, 2023

[Windows] Review currently failing Windows tests #15530

Open

32 tasks

PureWeen commented Jun 8, 2023

View reviewed changes

src/Controls/tests/DeviceTests/Elements/ListView/ListViewTests.cs

[Fact]

[Fact

#if WINDOWS

(Skip = "Failing")

Copy link

Member Author

PureWeen Jun 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#15530

PureWeen commented Jun 8, 2023

View reviewed changes

PureWeen changed the title ~~Skip tests currently having issues~~ Skip tests currently having issues on WinUI Jun 8, 2023

PureWeen marked this pull request as ready for review June 8, 2023 16:24

Eilon added the area/infrastructure 🏗️ CI, Maestro / Coherency label Jun 8, 2023

- fix compile errors

e3337fc

jsuarezruiz approved these changes Jun 9, 2023

View reviewed changes

PureWeen merged commit ba767fd into main Jun 9, 2023
27 of 28 checks passed

PureWeen deleted the baseline_winui_tests branch June 9, 2023 14:13

github-actions bot locked and limited conversation to collaborators Dec 9, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Skip tests currently having issues on WinUI #15527

Skip tests currently having issues on WinUI #15527

PureWeen commented Jun 8, 2023 •

edited

PureWeen Jun 8, 2023

PureWeen Jun 8, 2023

PureWeen Jun 8, 2023

PureWeen Jun 8, 2023

PureWeen Jun 8, 2023

PureWeen Jun 8, 2023

PureWeen Jun 8, 2023

PureWeen Jun 8, 2023

PureWeen Jun 8, 2023

PureWeen Jun 8, 2023

Skip tests currently having issues on WinUI #15527

Skip tests currently having issues on WinUI #15527

Conversation

PureWeen commented Jun 8, 2023 • edited

Description of Change

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PureWeen commented Jun 8, 2023 •

edited