[iOS] Fix gestures in Label Spans #15544

jsuarezruiz · 2023-06-09T10:14:51Z

Description of Change

Fix gestures in Label Spans on iOS.

To test/validate the changes, open the .NET MAUI Gallery and navigate to the Label page. Tap the Span with the text "Click Me". If the Span changes the TextColor, is working as expected.

Also tested using the Issue3525 UI Test.

Issues Fixed

Fixes #8004
Fixes #4734

src/Controls/src/Core/Label/Label.iOS.cs

mattleibow · 2023-06-29T15:09:09Z

Is there a reason this is still in draft @jsuarezruiz?

mattleibow · 2023-06-29T15:09:16Z

/rebase

jsuarezruiz · 2023-06-30T07:37:19Z

src/Controls/src/Core/Platform/iOS/Extensions/FormattedStringExtensions.cs

@@ -124,5 +126,116 @@ public static class FormattedStringExtensions

 			return attrString;
 		}
+
+		public static void RecalculateSpanPositions(this UILabel control, Label element)


This comes from Xamarin.Forms, although in .NET MAUI I see an incorrect calculation of the Region that defines the limits of each Span when there are multiple lines.

jsuarezruiz · 2023-06-30T07:41:02Z

Is there a reason this is still in draft @jsuarezruiz?

Yes, sorry. All my open PRs, are Draft except 4 to focus on them, speed up merges and reduce the number of open PRs (20 at the moment).

src/Core/src/Platform/iOS/MauiLabel.cs

jsuarezruiz · 2023-08-17T10:24:04Z

Added UI Test.

samhouts · 2023-09-11T23:03:46Z

Tests are failing?

ghost · 2023-09-11T23:03:58Z

Hi @jsuarezruiz. We have added the "s/pr-needs-author-input" label to this issue, which indicates that we have an open question/action for you before we can take further action. This PRwill be closed automatically in 14 days if we do not hear back from you by then - please feel free to re-open it if you come back to this PR after that time.

PureWeen

I re-enabled the span tests on this one. It looks like Issue4734Test ian't passing. Ignore the rest of the tests, those will be fixed by different PRs and aren't related to this one.

https://dev.azure.com/xamarin/public/_build/results?buildId=96398&view=ms.vss-test-web.build-test-results-tab&runId=2113711&resultId=100004&paneView=debug

src/Controls/tests/UITests/Tests/Issues/Issue3525.cs

tj-devel709 · 2024-02-07T14:55:26Z

iOS update	Android update
iOS_Span_update1.mov	android_Span_update1.mov

tj-devel709 · 2024-02-07T14:58:47Z

src/Controls/src/Core/Region.cs

 			{
 				var region = Regions[i];

-				if (i == 0) // this is the first line
-					region.Top -= top;
+				region.Top -= top;

 				region.Left -= left;
 				region.Width += right + left;

-				if (i == Regions.Count - 1) // This is the last line
-					region.Height += bottom + top;
+				region.Height += bottom + top;

 				rectangles[i] = region;


Made these changes since moving the region up but not making it bigger only really makes sense if we can guarantee that the next line will be right below the top line. This doesn't work in cases where the top line is at the end of the line and goes a little onto the next line for example.

tj-devel709 · 2024-02-08T15:42:51Z

Waiting for the iOS UITests to work again!

jsuarezruiz

Tested on simulator and device:

The touch region works really nice.
The build is failing with some Android UITests failing. All the failing tests fails because a timeout "OneTimeSetUp: System.TimeoutException : Timed out waiting for Go To Test button to appear", probably one of the tests is crashing or closing the App and from that point the rest fails on cascade.

src/Controls/src/Core/Platform/iOS/Extensions/FormattedStringExtensions.cs

PureWeen · 2024-02-14T20:10:54Z

/rebase

commit 694fba9 Merge: b388f57 1f21047 Author: Javier Suárez <javiersuarezruiz@hotmail.com> Date: Mon Dec 4 12:03:39 2023 +0100 Merge branch 'main' into fix-4734-ios commit b388f57 Author: Javier Suárez <javiersuarezruiz@hotmail.com> Date: Thu Nov 30 08:59:24 2023 +0100 Updated tests commit 89353df Author: Javier Suárez <javiersuarezruiz@hotmail.com> Date: Wed Nov 29 17:29:14 2023 +0100 Fix merge issue commit 99db35e Merge: fdb7113 4a31ee1 Author: Javier Suárez <javiersuarezruiz@hotmail.com> Date: Tue Nov 28 13:50:36 2023 +0100 Merge branch 'main' into fix-4734-ios commit fdb7113 Merge: ad27d6e f6956cb Author: Javier Suárez <javiersuarezruiz@hotmail.com> Date: Fri Nov 3 09:08:01 2023 +0100 Merge branch 'main' into fix-4734-ios commit ad27d6e Merge: c87a842 783db24 Author: Javier Suárez <javiersuarezruiz@hotmail.com> Date: Wed Oct 25 14:07:27 2023 +0200 Merge branch 'main' into fix-4734-ios commit c87a842 Merge: a507d1e e25d331 Author: Javier Suárez <javiersuarezruiz@hotmail.com> Date: Fri Oct 20 13:34:23 2023 +0200 Merge branch 'main' into fix-4734-ios commit a507d1e Author: Javier Suárez <javiersuarezruiz@hotmail.com> Date: Wed Oct 18 17:13:11 2023 +0200 Updated test commit aa0f949 Merge: b12077e 3bd8421 Author: Javier Suárez <javiersuarezruiz@hotmail.com> Date: Wed Oct 18 13:25:01 2023 +0200 Merge branch 'main' into fix-4734-ios commit b12077e Merge: 8e45456 0f764ac Author: Javier Suárez <javiersuarezruiz@hotmail.com> Date: Wed Oct 18 08:40:46 2023 +0200 Merge branch 'main' into fix-4734-ios commit 8e45456 Author: Javier Suárez <javiersuarezruiz@hotmail.com> Date: Fri Oct 6 11:47:49 2023 +0200 Fix the test commit 08176dc Author: Javier Suárez <javiersuarezruiz@hotmail.com> Date: Thu Oct 5 12:30:35 2023 +0200 Updated test commit e7ed571 Author: Javier Suárez <javiersuarezruiz@hotmail.com> Date: Wed Oct 4 14:20:15 2023 +0200 Updated test commit 93e8095 Merge: 1145f10 a05a5a7 Author: Javier Suárez <javiersuarezruiz@hotmail.com> Date: Wed Oct 4 13:52:29 2023 +0200 Merge branch 'main' into fix-4734-ios commit 1145f10 Author: Javier Suárez <javiersuarezruiz@hotmail.com> Date: Fri Sep 29 11:46:28 2023 +0200 Update src/Controls/tests/UITests/Tests/Issues/Issue3525.cs Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> commit 6f272d4 Author: Javier Suárez <javiersuarezruiz@hotmail.com> Date: Thu Sep 28 16:23:00 2023 +0200 Changes in tests commit 7c8d533 Merge: b69cc28 9895399 Author: Javier Suárez <javiersuarezruiz@hotmail.com> Date: Wed Sep 27 10:51:18 2023 +0200 Merge branch 'main' into fix-4734-ios commit b69cc28 Author: Shane Neuville <shneuvil@microsoft.com> Date: Sun Sep 17 10:41:12 2023 -0500 - add span tests back commit 3f4b36b Merge: c21fe9a fdbeb81 Author: Shane Neuville (HE/HIM) <shneuvil@microsoft.com> Date: Sun Sep 17 10:34:32 2023 -0500 Merge remote-tracking branch 'origin/main' into fix-4734-ios commit c21fe9a Author: Javier Suárez <javiersuarezruiz@hotmail.com> Date: Wed Sep 13 15:55:22 2023 +0200 Fix build errors commit 0669553 Merge: fdf5296 aff9b34 Author: Javier Suárez <javiersuarezruiz@hotmail.com> Date: Tue Sep 12 13:02:14 2023 +0200 Merge branch 'main' into fix-4734-ios commit fdf5296 Merge: ee2cd4e ace9fe5 Author: Javier Suárez <javiersuarezruiz@hotmail.com> Date: Fri Aug 18 09:02:59 2023 +0200 Merge branch 'main' into fix-4734-ios commit ee2cd4e Author: Javier Suárez <javiersuarezruiz@hotmail.com> Date: Thu Aug 17 12:23:35 2023 +0200 Remove unnecessary event in iOS MauiLabel commit cd8098f Author: Javier Suárez <javiersuarezruiz@hotmail.com> Date: Thu Aug 17 12:13:20 2023 +0200 Changes in test commit 797872d Author: Javier Suárez <javiersuarezruiz@hotmail.com> Date: Thu Aug 17 12:12:46 2023 +0200 Fix build error commit 5c7ff39 Author: Javier Suárez <javiersuarezruiz@hotmail.com> Date: Thu Aug 17 11:53:06 2023 +0200 Added UI Test commit deaf66d Merge: b68a52d 34b481d Author: Javier Suárez <javiersuarezruiz@hotmail.com> Date: Thu Aug 17 09:57:08 2023 +0200 Merge branch 'main' into fix-4734-ios commit b68a52d Merge: 4854977 e6a4334 Author: Javier Suárez <javiersuarezruiz@hotmail.com> Date: Thu Aug 3 15:44:30 2023 +0200 Merge branch 'main' into fix-4734-ios commit 4854977 Merge: 74a8d7a f241014 Author: Javier Suárez <javiersuarezruiz@hotmail.com> Date: Tue Jul 25 12:00:27 2023 +0200 Merge branch 'main' into fix-4734-ios commit 74a8d7a Merge: b62d39d 443d3a0 Author: Javier Suárez <javiersuarezruiz@hotmail.com> Date: Tue Jul 18 11:49:35 2023 +0200 Merge branch 'main' into fix-4734-ios commit b62d39d Merge: 05b0495 b9f64e1 Author: Javier Suárez <javiersuarezruiz@hotmail.com> Date: Tue Jul 11 12:42:20 2023 +0200 Merge branch 'main' into fix-4734-ios commit 05b0495 Author: Javier Suárez <javiersuarezruiz@hotmail.com> Date: Thu Jul 6 12:16:43 2023 +0200 Fix the build commit b717d17 Merge: b1543a3 700944b Author: Javier Suárez <javiersuarezruiz@hotmail.com> Date: Wed Jul 5 09:12:33 2023 +0200 Merge branch 'main' into fix-4734-ios commit b1543a3 Merge: d55348b db60162 Author: Javier Suárez <javiersuarezruiz@hotmail.com> Date: Fri Jun 30 09:41:55 2023 +0200 Merge branch 'main' into fix-4734-ios commit d55348b Author: Javier Suárez <javiersuarezruiz@hotmail.com> Date: Fri Jun 23 19:34:48 2023 +0200 Fix broken tests commit f48ca85 Merge: a725311 3622625 Author: Javier Suárez <javiersuarezruiz@hotmail.com> Date: Thu Jun 22 11:56:09 2023 +0200 Merge branch 'main' into fix-4734-ios commit a725311 Merge: 3d4326c b7afc3b Author: Javier Suárez <javiersuarezruiz@hotmail.com> Date: Wed Jun 14 12:00:53 2023 +0200 Merge branch 'main' into fix-4734-ios commit 3d4326c Merge: e99fa67 233fa2f Author: Matthew Leibowitz <mattleibow@live.com> Date: Thu May 18 19:53:40 2023 +0800 Merge remote-tracking branch 'origin/main' into fix-4734-ios commit e99fa67 Author: Javier Suárez <javiersuarezruiz@hotmail.com> Date: Wed May 10 10:11:43 2023 +0200 More changes commit 9c45894 Author: Javier Suárez <javiersuarezruiz@hotmail.com> Date: Wed May 10 10:11:35 2023 +0200 More changes commit a0747e4 Author: Javier Suárez <javiersuarezruiz@hotmail.com> Date: Wed May 10 10:01:00 2023 +0200 Fix span gestures on iOS Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com>

jameslavery · 2024-02-15T07:04:56Z

Can someone confirm that this is fixed for Windows too, please?

sjorsmiltenburg · 2024-02-15T08:18:14Z

yep, I desperately need this for windows too

RobTF · 2024-03-04T12:52:29Z

What version of .NET MAUI will this fix appear in? We have users complaining they can't tap links on iOS and we'd like to be able to give an ETA on the fix.

thanks

MartyIX · 2024-03-04T12:58:53Z

Can someone confirm that this is fixed for Windows too, please?

You can try a nightly build (https://github.com/dotnet/maui/wiki/Nightly-Builds) to verify if the PR fixes your issue.

MartyIX · 2024-03-04T13:00:59Z

What version of .NET MAUI will this fix appear in? We have users complaining they can't tap links on iOS and we'd like to be able to give an ETA on the fix.

thanks

Not a MAUI team member but https://github.com/orgs/dotnet/projects/194/views/22?pane=issue&itemId=15608832 shows that it should be released as a part of the SR3 release. So hopefully at most weeks. No guarantees.

RobTF · 2024-03-04T13:02:39Z

Thanks @MartyIX. We wouldn't generally play with the nightly builds as we can't use them in production anyway, so we're interested in getting a version/date of when the fix is officially released but thanks or the idea and looking into it for me. I struggled to find that page.

vallgrenerik · 2024-03-18T13:44:00Z

Can confirm that this solves my problem on iOS
Update to:

<PackageReference Include="Microsoft.Maui.Controls" Version="8.0.10" />
<PackageReference Include="Microsoft.Maui.Controls.Compatibility" Version="8.0.10" />

Then clean and build! 👏

RobTF · 2024-03-18T13:45:04Z

Yes we spotted this fix is in SR3, thanks!

kimhongka · 2024-03-27T23:32:02Z

Found this issue happens when the Label with Span Gensture is wrapped with Frame. It is still a bug. The workaround solution for this is using Border control instead of Frame.

alexKuchyk-godel · 2024-04-02T08:30:58Z

issue still reproduced on iOS

RobTF · 2024-04-02T08:32:27Z

We found that this issue was fixed in SR3 - has it regressed in SR3.1?

alexKuchyk-godel · 2024-04-02T08:45:31Z

Issue still reproduced on:

<PackageReference Include="Microsoft.Maui.Controls" Version="8.0.14" />
<PackageReference Include="Microsoft.Maui.Controls.Compatibility" Version="8.0.14" />

Maybe I missed something?

zleao · 2024-04-03T15:06:06Z

Same here.
Not working on iPhone and iPad...
Using the same versions as @alexKuchyk-godel

varyamereon · 2024-04-05T12:58:44Z

Same here, disappointing, have been waiting for this fix for a long time.

I have tried to make a reproduction sample but it works there using a ScrollView->VerticalStackLayout->Grid->Label->Span. Using exactly the same in my production app and the command doesn't fire 🤷🏻‍♂️

jsuarezruiz added t/bug Something isn't working platform/iOS 🍎 area/gestures labels Jun 9, 2023

jsuarezruiz commented Jun 23, 2023

View reviewed changes

src/Controls/src/Core/Label/Label.iOS.cs Outdated Show resolved Hide resolved

jfversluis mentioned this pull request Jun 27, 2023

Gestures don't work on Label Spans #4734

Closed

4 tasks

jsuarezruiz commented Jun 30, 2023

View reviewed changes

Redth added this to the .NET 8 GA milestone Jul 18, 2023

PureWeen requested changes Aug 16, 2023

View reviewed changes

src/Core/src/Platform/iOS/MauiLabel.cs Outdated Show resolved Hide resolved

jsuarezruiz requested a review from PureWeen August 17, 2023 10:23

jsuarezruiz marked this pull request as ready for review August 17, 2023 10:24

jsuarezruiz requested a review from a team as a code owner August 17, 2023 10:24

jsuarezruiz requested a review from jfversluis August 17, 2023 10:24

samhouts added the stale Indicates a stale issue/pr and will be closed soon label Sep 11, 2023

samhouts added the s/pr-needs-author-input PR needs an update from the author label Sep 11, 2023

ghost removed stale Indicates a stale issue/pr and will be closed soon s/pr-needs-author-input PR needs an update from the author labels Sep 12, 2023

PureWeen requested changes Sep 17, 2023

View reviewed changes

samhouts modified the milestones: .NET 8 GA, Under Consideration Sep 19, 2023

PureWeen modified the milestones: Under Consideration, .NET 8 GA, .NET 8 SR1 Sep 24, 2023

jfversluis approved these changes Sep 29, 2023

View reviewed changes

src/Controls/tests/UITests/Tests/Issues/Issue3525.cs Outdated Show resolved Hide resolved

tj-devel709 reviewed Feb 7, 2024

View reviewed changes

jsuarezruiz commented Feb 9, 2024

View reviewed changes

PureWeen reviewed Feb 12, 2024

View reviewed changes

src/Controls/src/Core/Platform/iOS/Extensions/FormattedStringExtensions.cs Outdated Show resolved Hide resolved

mattleibow and others added 6 commits February 14, 2024 20:11

Removed duplicated test

e94d90e

I think the span gestures look pretty good now

166ddcc

Fix edge case with new line

c7cfdfc

remove comment

8a10994

make RecalculateSpanPositions internal

8d6e929

github-actions bot force-pushed the fix-4734-ios branch from 0092668 to 8d6e929 Compare February 14, 2024 20:11

PureWeen approved these changes Feb 14, 2024

View reviewed changes

PureWeen merged commit b2f64f2 into main Feb 15, 2024
44 of 49 checks passed

PureWeen deleted the fix-4734-ios branch February 15, 2024 05:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[iOS] Fix gestures in Label Spans #15544

[iOS] Fix gestures in Label Spans #15544

jsuarezruiz commented Jun 9, 2023 •

edited

mattleibow commented Jun 29, 2023

mattleibow commented Jun 29, 2023

jsuarezruiz Jun 30, 2023

jsuarezruiz commented Jun 30, 2023

jsuarezruiz commented Aug 17, 2023

samhouts commented Sep 11, 2023

ghost commented Sep 11, 2023

PureWeen left a comment •

edited

tj-devel709 commented Feb 7, 2024

tj-devel709 Feb 7, 2024

tj-devel709 commented Feb 8, 2024

jsuarezruiz left a comment

PureWeen commented Feb 14, 2024

jameslavery commented Feb 15, 2024

sjorsmiltenburg commented Feb 15, 2024

RobTF commented Mar 4, 2024 •

edited

MartyIX commented Mar 4, 2024

MartyIX commented Mar 4, 2024

RobTF commented Mar 4, 2024

vallgrenerik commented Mar 18, 2024 •

edited

RobTF commented Mar 18, 2024

kimhongka commented Mar 27, 2024 •

edited

alexKuchyk-godel commented Apr 2, 2024

RobTF commented Apr 2, 2024

alexKuchyk-godel commented Apr 2, 2024

zleao commented Apr 3, 2024 •

edited

varyamereon commented Apr 5, 2024 •

edited

[iOS] Fix gestures in Label Spans #15544

[iOS] Fix gestures in Label Spans #15544

Conversation

jsuarezruiz commented Jun 9, 2023 • edited

Description of Change

Issues Fixed

mattleibow commented Jun 29, 2023

mattleibow commented Jun 29, 2023

jsuarezruiz Jun 30, 2023

Choose a reason for hiding this comment

jsuarezruiz commented Jun 30, 2023

jsuarezruiz commented Aug 17, 2023

samhouts commented Sep 11, 2023

ghost commented Sep 11, 2023

PureWeen left a comment • edited

Choose a reason for hiding this comment

tj-devel709 commented Feb 7, 2024

tj-devel709 Feb 7, 2024

Choose a reason for hiding this comment

tj-devel709 commented Feb 8, 2024

jsuarezruiz left a comment

Choose a reason for hiding this comment

PureWeen commented Feb 14, 2024

jameslavery commented Feb 15, 2024

sjorsmiltenburg commented Feb 15, 2024

RobTF commented Mar 4, 2024 • edited

MartyIX commented Mar 4, 2024

MartyIX commented Mar 4, 2024

RobTF commented Mar 4, 2024

vallgrenerik commented Mar 18, 2024 • edited

RobTF commented Mar 18, 2024

kimhongka commented Mar 27, 2024 • edited

alexKuchyk-godel commented Apr 2, 2024

RobTF commented Apr 2, 2024

alexKuchyk-godel commented Apr 2, 2024

zleao commented Apr 3, 2024 • edited

varyamereon commented Apr 5, 2024 • edited

jsuarezruiz commented Jun 9, 2023 •

edited

PureWeen left a comment •

edited

RobTF commented Mar 4, 2024 •

edited

vallgrenerik commented Mar 18, 2024 •

edited

kimhongka commented Mar 27, 2024 •

edited

zleao commented Apr 3, 2024 •

edited

varyamereon commented Apr 5, 2024 •

edited