[iOS] Allow to remove the Image from Button #15624
Merged
+15
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
added
t/bug
ghost
added
the
area/controls 🎮
jsuarezruiz
commented
Jun 14, 2023
| @@ -146,11 +146,6 @@ void OnSetImageSource(UIImage? image) | |||
|
|
|||
| public static Task MapImageSourceAsync(IButtonHandler handler, IImage image) | |||
| { | |||
| if (image.Source == null) | |||
There was a problem hiding this comment.
This is the main change. This prevents that once the image is set it can be updated with something null.
rmarinho
approved these changes
Jun 19, 2023
Eilon
removed
the
area/controls 🎮
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Allow to remove the Image from iOS Button.
To validate the changes can use the Button samples from the .NET MAUI Gallery.
Issues Fixed
Fixes #15006