Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[net8.0] Use darc for packs from runtime #15731

Merged
merged 1 commit into from Jun 22, 2023

Conversation

lewing
Copy link
Member

@lewing lewing commented Jun 19, 2023

Description of Change

Use flow for the packages that come from runtime

@ghost ghost added the community ✨ Community Contribution label Jun 19, 2023
@ghost
Copy link

ghost commented Jun 19, 2023

Hey there @lewing! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@lewing lewing changed the title Use darc for packs from runtime [net8.0] Use darc for packs from runtime Jun 19, 2023
@lewing lewing marked this pull request as ready for review June 20, 2023 14:15
@lewing
Copy link
Member Author

lewing commented Jun 20, 2023

Is there a reason these were being versioned separately?

@rmarinho
Copy link
Member

@mattleibow are these where we need specific versions because of VS ?

@rmarinho
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@Redth Redth requested a review from rmarinho June 20, 2023 15:44
@Eilon Eilon added the area/infrastructure 🏗️ CI, Maestro / Coherency label Jun 20, 2023
@rmarinho rmarinho self-assigned this Jun 21, 2023
@mattleibow
Copy link
Member

I think before it was matching the version of the IDE, but now we just ship it - we never really added these packages to the darc list. Just ad-hoc updated.

@rmarinho rmarinho merged commit 6d6d7c6 into dotnet:net8.0 Jun 22, 2023
27 checks passed
@lewing lewing deleted the lewing/flow-runtime-packs branch June 29, 2023 16:31
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/infrastructure 🏗️ CI, Maestro / Coherency community ✨ Community Contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants