Streamline ModalNavigation lifecycle events #15799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
added
area/navigation 🧭
rmarinho
reviewed
Jun 26, 2023
src/Controls/src/Core/Platform/ModalNavigationManager/ModalNavigationManager.cs
Show resolved
Hide resolved
jknaudt21
reviewed
Jul 5, 2023
jknaudt21
approved these changes
Jul 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
When the toolbar code was modified to wire up during the windows changed event, this wasn't properly accounted for inside the
Shellmodal workflow. This PR consolidates the lifecycle handling of modals a bit more into theModalNavigationManagerto ensure that parents are set and LC events are thrown all in the correct order.Issues Fixed
Fixes #15498