[net8.0] Merge main to net8.0 branch #15931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#15791) * Update and rename dotnet-format-daily.yml to dotnet-format-daily-net7.yml * Create dotnet-format-daily-main.yml * Update dotnet-format-daily-main.yml * Update dotnet-format-daily-net7.yml
…30621.2 (#15857) Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit From Version 8.0.0-prerelease.23312.1 -> To Version 8.0.0-prerelease.23321.2 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Context: #14664 Context: https://github.com/nacompllo/MemoryLeakEverywhere/tree/bugfix/memoryLeakItemsSource In reviewing our latest changes in main with the above customer sample, I found that there appeared to be leaks related to MAUI's `UITableViewCell` subclasses when using `CollectionView`. I was able to reproduce the issue in a test, such as: // DataTemplate saves WeakReference to the View in a list collectionView.ItemTemplate = new DataTemplate(() => { var label = new Label(); labels.Add(new(label)); return label; }); // Create a cell and bind it to the template: cell = new VerticalCell(CGRect.Empty); cell.Bind(collectionView.ItemTemplate, bindingContext, collectionView); // Check we have no leaks foreach (var reference in labels) { Assert.False(reference.IsAlive, "View should not be alive!"); } After isolating the issue, I found the issue was the `TemplatedCell.PlatformHandler` property: internal IPlatformViewHandler PlatformHandler { get; private set; } This stores a copy of the `LabelHandler` in our test/example. The problem with `UITableViewCell` is that UIKit holds onto these and reuses them. This means that UIKit may keep the `LabelHandler` alive longer than needed. It also appears to be a somewhat complex circular reference: * `CollectionView` -> handlers / etc. -> `TemplatedCell` -> `LabelHandler` -> `Label` -> `CollectionView` I made the `PlatformHandler` use a `WeakReference` as its backing field and the problem goes away! I will retest #14664 to verify if it is fully solved.
* Optimize iOS selection synchronization not to use O(n^2) algorithm and to respect GetHashCode/Equals overrides instead of relying on reference equality. * Fix few more places where reference equality was used instead of object equality.
* fix(shell): Fixed removing items from the shell causing a crash * Auto-format source code * Use null terminator * Add device tests * PR feedback, move test to run on all devices --------- Co-authored-by: Mike Corsaro <mikecorsaro@microsoft.com> Co-authored-by: GitHub Actions Autoformatter <autoformat@example.com> Co-authored-by: Rui Marinho <me@ruimarinho.net>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Fix crash swapping MainPage on Windows * Updated tests * Fix crash swapping MainPage on Windows * Updated tests * Updated Impl * More changes * Updated test * Changes from feedback --------- Co-authored-by: Javier Suárez <6755973+jsuarezruiz@users.noreply.github.com>
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 17.6.2 to 17.6.3. - [Release notes](https://github.com/microsoft/vstest/releases) - [Changelog](https://github.com/microsoft/vstest/blob/main/docs/releases.md) - [Commits](microsoft/vstest@v17.6.2...v17.6.3) --- updated-dependencies: - dependency-name: Microsoft.NET.Test.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Wait for switched item to load * - fix edge case where a shell page is removed during load
* Use default StepFrequency and SmallChange values * Only remove SmallChange
Bumps [powershell](https://github.com/PowerShell/PowerShell) from 7.3.4 to 7.3.5. - [Release notes](https://github.com/PowerShell/PowerShell/releases) - [Commits](PowerShell/PowerShell@v7.3.4...v7.3.5) --- updated-dependencies: - dependency-name: powershell dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Fix PointerGesture CommandParameter properties * Add tests
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
PureWeen
approved these changes
Jun 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Update net8 branch with latest fixes