[tests] make Windows memory leak tests consistent #15998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes part of: dotnet#15530 These would fail randomly for me when I ran them. But after reviewing memory snapshots, I didn't find an actual issue the tests were just flaky. I found I could rework the tests to do: await AssertionExtensions.Wait(() => { GC.Collect(); GC.WaitForPendingFinalizers(); return !pageReference.IsAlive; }, timeout: 5000); And now they pass every time for me locally. So it waits up to 5 seconds, and quits early if the page is gone. If this still passes on all platforms -- we should just use this instead.
PureWeen
approved these changes
Jul 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes part of: #15530
These would fail randomly for me when I ran them. But after reviewing memory snapshots, I didn't find an actual issue the tests were just flaky.
I found I could rework the tests to do:
And now they pass every time for me locally.
So, it waits up to 5 seconds, and quits early if the page is gone.
If this still passes on all platforms -- we can probably use this instead.