New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a UI test for tapping on a label span #16222
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattleibow
commented
Jul 19, 2023
mattleibow
commented
Jul 19, 2023
This was referenced Jul 19, 2023
I have this PR to merge this PR with the span's Frame changes: |
sbanni
reviewed
Jul 19, 2023
sbanni
previously approved these changes
Jul 26, 2023
mattleibow
force-pushed
the
dev/label-tap
branch
from
July 27, 2023 18:18
d8339de
to
3e9dd79
Compare
jknaudt21
previously approved these changes
Jul 28, 2023
# Conflicts: # src/Controls/tests/UITests/Tests/UITestBase.cs
rmarinho
reviewed
Jul 31, 2023
# Conflicts: # src/Controls/samples/Controls.Sample.UITests/CoreViews/CorePageView.cs # src/TestUtils/src/TestUtils.Appium.UITests/AppiumUITestApp.cs
rmarinho
approved these changes
Aug 17, 2023
rmarinho
pushed a commit
that referenced
this pull request
Aug 19, 2023
* Squashed commit of the following: * case * screenshots * try adding a type name * Try capture things * Fix the changes after a merge --------- Co-authored-by: Shane Neuville <shneuvil@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR just adds a few UI tests for labels. The main label page is from the compat control gallery. I then added an additional test to track the tapping of a span in a label.