Don't use loaded/unloaded on FlyoutPage #16241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
force-pushed
the
fix_loaded_timing_flyout_page
branch
from
a47aef5
to
8a946c3
Compare
mattleibow
approved these changes
Jul 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The Legacy Gallery does a lot of page churn when it first starts up. It basically goes through the follow stages
The PR around LogicalChildren looks to have adjusted the timing just enough that we're hitting a race condition with the observers used to watch for loaded events on iOS.
We are going to remove these observers for RC1 so the race condition should become irrelevant at that point.