Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[net8.0] Fix Catalyst and Windows device tests #16343

Merged
merged 2 commits into from Jul 25, 2023
Merged

Conversation

rmarinho
Copy link
Member

@rmarinho rmarinho commented Jul 25, 2023

Description of Change

Some fixes made on the android PR related with DOTNET_ROOT were wrong.

Also I think this breaks running these commands locally with local workloads. So I might need to fix that in another PR.

@rmarinho rmarinho requested a review from a team as a code owner July 25, 2023 16:54
@rmarinho rmarinho changed the base branch from main to net8.0 July 25, 2023 16:54
@rmarinho rmarinho self-assigned this Jul 25, 2023
@rmarinho rmarinho requested review from PureWeen and Redth July 25, 2023 19:14
@rmarinho rmarinho changed the title [net8.0] Fix devicetests windows [net8.0] Fix Windows device tests Jul 25, 2023
@rmarinho rmarinho changed the title [net8.0] Fix Windows device tests [net8.0] Fix Catalyst and Windows device tests Jul 25, 2023
@rmarinho rmarinho requested a review from Eilon July 25, 2023 20:40
@rmarinho rmarinho enabled auto-merge (squash) July 25, 2023 20:53
@rmarinho rmarinho merged commit b92a660 into net8.0 Jul 25, 2023
39 of 40 checks passed
@rmarinho rmarinho deleted the fix-devicetests-windows branch July 25, 2023 21:12
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2023
@samhouts samhouts added platform/macOS 🍏 macOS / Mac Catalyst platform/windows 🪟 area/testing Unit tests, device tests labels Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/testing Unit tests, device tests platform/macOS 🍏 macOS / Mac Catalyst platform/windows 🪟
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants