[net7.0] Revert default for UseSafeAreaProperty to value from .NET 6 for iOS #16379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…16093) * Revert default for UseSafeAreaProperty to value from .NET 6 for iOS Fixes #12823 * Update to ignore broken iOS test for now * Fix shell tab test # Conflicts: # src/Controls/tests/DeviceTests/Elements/Shell/ShellTests.iOS.cs # src/Controls/tests/DeviceTests/Elements/TabbedPage/TabbedPageTests.cs
|
We might need to pause on this until we resolve this issue If you compare shell here before/after this PR you'll see the follow differences. I tested this on XF and didn't see a layout change on XF when changing this value. 
|
|
Having thought through it a bit more, I think this one is fine to backport There's a lot of very random code for handling SafeAreas in forms that's really hard to stay consistent with. Right now having NET7 be different from NET6/NET8 and Xamarin.Forms is probably the worst of the options. The issue we eventually need to address in MAUI is accounting for SafeArea and SCrollViews. We should have some sort of safe area indicator on ScrollView that effects the adjustedContentInset on a UIScrollView |
jknaudt21
approved these changes
Aug 18, 2023
samhouts
approved these changes
Aug 18, 2023
PureWeen
pushed a commit
that referenced
this pull request
Sep 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #16093 to net7.0
/cc @hartez
One thing to consider
#16352