New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dotnet-local
scripts to make using in tree dotnet easier.
#16461
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall these scripts are going to be useful in .NET 8, they dropped support for $DOTNET_HOST_PATH
and $DOTNET_ROOT
.
So, if you tried to run ./bin/dotnet/dotnet build someproject.sproj
, the <Csc/>
task might pick up a different dotnet
and the build will fail.
dotnet-local.cmd
Outdated
SET PATH=%DOTNET_ROOT%;%PATH% | ||
call "%ROOT%\bin\dotnet\dotnet.exe" %* | ||
) ELSE ( | ||
echo "You need to run 'build.ps1' first." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @PureWeen I'm not sure we use those build.ps1/sh
scripts or are they are vestigial? I think we could just say, "you need to build MAUI first" and link to:
https://github.com/dotnet/maui/blob/main/.github/DEVELOPMENT.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the one hand, sure, but on the other hand… I find that .github/DEVELOPMENT.md
page to be inscrutable. How should I build dotnet/maui if I don't use build.sh
/build.ps1
?
And if build.sh
/build.ps1
shouldn't be used, shouldn't we just delete them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I don't know why they exist if DEVELOPMENT.md
doesn't mention them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We were using build.sh
and build.ps1
before dotnet had a cake tool and before anyone that didn't work here could even hope to build MAUI.
We could probably just delete them at this point
One issue with this comment is that I don't see anything "contributor-facing" within dotnet/maui which uses What I do know is that if |
@PureWeen , @jonathanpeppers: error message has been updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The scripts themselves look good now. ./bin/dotnet/dotnet
will not be useable without them on the net8.0
branch currently.
/rebase |
Using `dotnet` may require setting `%PATH%` to prefer `bin\dotnet\dotnet` over any other `dotnet` in `%PATH%`. Usage: # Unix path/to/maui/dotnet-local.sh build App.sln rem Windows path\to\maui\dotnet-local.cmd build App.sln If MAUI hasn't been built yet, an error message stating that `build.sh` or `build.ps1` should be executed is printed.
53ec33b
to
6d7b5f6
Compare
Using
dotnet
may require setting%PATH%
to preferbin\dotnet\dotnet
over any otherdotnet
in%PATH%
.Usage:
If MAUI hasn't been built yet, an error message stating that
build.sh
orbuild.ps1
should be executed is printed.