Allow * rows/columns treated as Auto to expand during 2nd measure pass #16488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
added
the
backport/suggested
|
/azp run |
|
No commit pushedDate could be found for PR 16488 in repo dotnet/maui |
Eilon
added
the
area/layout 🔲
|
/azp run MAUI-DeviceTests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rmarinho
approved these changes
Aug 3, 2023
| @@ -480,7 +480,7 @@ void SecondMeasurePass() | |||
| } | |||
| else if (cell.ColumnSpan == 1) | |||
| { | |||
| if (_columns[cell.Column].IsAuto) | |||
| if (TreatCellWidthAsAuto(cell)) | |||
There was a problem hiding this comment.
Should we add a comment why the corner case?
samhouts
approved these changes
Aug 3, 2023
|
/backport to net7.0 |
PureWeen
added
the
backport/approved
|
Started backporting to net7.0: https://github.com/dotnet/maui/actions/runs/5811126482 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
A confluence of Auto columns/rows in one dimension and de facto Auto columns/rows in the other dimension (because of a container layout which gives that dimension an unconstrained measurement) is causing an erroneous size value for a Star row/column. This change allows the Star row/column value to be updated to account for the size of the largest child View.
Our unit tests were technically covering a slight variation of this situation, but an error in the test setup meant that the two tests covering the scenario were passing inaccurately. This PR updates the test methods to account for the problem (by disallowing the test Views'
DesiredSizeproperty to return the test value prior to callingMeasure()). This PR also adds two additional tests specific to this scenario just in case.Issues Fixed
Fixes #16368
Fixes #16334