-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Android visual test screenshots more deterministic #16591
Conversation
Use the same nav bar style for the gallery pages and the issues pages. This looks better aesthetically and avoids an issue where issue page screenshots aren't consistent, depending on whether you've ever visited a gallery page or not. See more details in the Teams chat here: https://teams.microsoft.com/l/message/19:46c9eef68efe400393f538bd778e4718@thread.v2/1691428231798?context=%7B%22contextType%22%3A%22chat%22%7D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Teams chat is not accessible to me, but this sounds reasonable.
Looks like the test is failing on iOS and Windows now: https://dev.azure.com/xamarin/public/_build/results?buildId=92639&view=ms.vss-test-web.build-test-results-tab&runId=2055450&resultId=100012&paneView=debug
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to fix failing test(s).
@BretJohnson - iOS and Windows still seem sad 😢
|
Though, the % difference is lower now, so it's getting better 😉 |
* Use consistent nav bar styling Use the same nav bar style for the gallery pages and the issues pages. This looks better aesthetically and avoids an issue where issue page screenshots aren't consistent, depending on whether you've ever visited a gallery page or not. See more details in the Teams chat here: https://teams.microsoft.com/l/message/19:46c9eef68efe400393f538bd778e4718@thread.v2/1691428231798?context=%7B%22contextType%22%3A%22chat%22%7D * Crop off the 3 button nav at the bottom of Android screens. * Only call iOS SetPrefersLargeTitles on gallery pages * Update snapshots, with updated tabbar color
Make two changes so that Android visual test screenshots are more deterministic,
returning the same thing whether running locally or on CI, part of a single test run
or a batch test run:
Use the same nav bar style for the gallery pages and the issues pages. This looks better aesthetically and avoids an issue where issue page screenshots aren't consistent, depending on whether you've ever visited a gallery page or not.
Crop the 3 button nav from the bottom of the screen for Android. That UI isn't part of the app
and the color of the buttons can vary (they temporarily change to a different color when pressed).
Not including that UI in the screenshots avoids any spurious differences here.
See more details in the Teams chat:
https://teams.microsoft.com/l/message/19:46c9eef68efe400393f538bd778e4718@thread.v2/1691428231798?context=%7B%22contextType%22%3A%22chat%22%7D