Streamline SwipeView Children #16753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hartez
approved these changes
Aug 15, 2023
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Eilon
added
the
area/controls 🎮
rmarinho
pushed a commit
that referenced
this pull request
Aug 19, 2023
* Streamline SwipeView Children * - fix swipeview to not use legacy layout calls
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Alternate PR for #16632
Remove all the special code setting up the parents/children/BC propagation. Just lean into
AddLogicalChildrenThe original bug was that
OnBindingContextChangedonSwipeViewwas overridden and we weren't calledbase.OnBindingContextChangedwhich meant nothing would propagate down.Issues Fixed
Fixes #16345
Fixes #16742
Fixes #16855