Update VisualElement docs #16754
Update VisualElement docs #16754
Conversation
jfversluis
requested review from
StephaneDelcroix,
rachelkang,
hartez and
jknaudt21
|
We also need to document the explicit interface implementations since the docs tooling will not automatically grab these. Hopefully an A lot of them come from IView and IElement, and are properties we already have documented, such as To get a quick reference of the items that are missing, see: https://learn.microsoft.com/en-us/dotnet/api/microsoft.maui.controls.visualelement?view=net-maui-7.0#explicit-interface-implementations |
Co-authored-by: Samantha Houts <samhouts@users.noreply.github.com>
jfversluis
added
the
backport/suggested
|
Should be relatively easy to backport and will increase the coverage of the docs in vCurrent |
hartez
added
the
backport/approved
This comment was marked as outdated.
This comment was marked as outdated.
1 similar comment
|
/backport to net7.0 |
|
Started backporting to net7.0: https://github.com/dotnet/maui/actions/runs/5965392598 |
|
@jfversluis backporting to net7.0 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: First set of comments
Using index info to reconstruct a base tree...
A src/Controls/src/Core/VisualElement/VisualElement.cs
Falling back to patching base and 3-way merge...
Auto-merging src/Controls/src/Core/VisualElement.cs
CONFLICT (content): Merge conflict in src/Controls/src/Core/VisualElement.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 First set of comments
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
|
@jfversluis an error occurred while backporting to net7.0, please check the run log for details! Error: git am failed, most likely due to a merge conflict. |
|
Yeah I thought as much... |
* First set of comments * More comments * Finish! * PR Feedback * More PR feedback * Apply suggestions from code review Co-authored-by: Samantha Houts <samhouts@users.noreply.github.com> --------- Co-authored-by: Samantha Houts <samhouts@users.noreply.github.com>
* Update VisualElement docs (#16754) * First set of comments * More comments * Finish! * PR Feedback * More PR feedback * Apply suggestions from code review Co-authored-by: Samantha Houts <samhouts@users.noreply.github.com> --------- Co-authored-by: Samantha Houts <samhouts@users.noreply.github.com> * Fix build error --------- Co-authored-by: Samantha Houts <samhouts@users.noreply.github.com> Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com>
Description of Change
Moves the external comments to inline, adds missing comments and minor improvements.
Issues Fixed
Related to #3960