Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MauiEmbedding extensions should use specified TApp type #16758

Merged
merged 1 commit into from Aug 16, 2023
Merged

MauiEmbedding extensions should use specified TApp type #16758

merged 1 commit into from Aug 16, 2023

Conversation

dansiegel
Copy link
Contributor

Description of Change

Fixes registration extensions for UseMauiEmbedding. The extensions now use the TApp specified in the extension.

Issues Fixed

Fixes #16757

@dansiegel dansiegel requested a review from a team as a code owner August 15, 2023 12:50
@ghost ghost added the community ✨ Community Contribution label Aug 15, 2023
@ghost
Copy link

ghost commented Aug 15, 2023

Hey there @dansiegel! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@samhouts samhouts added this to the Under Consideration milestone Aug 15, 2023
drasticactions
drasticactions approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@drasticactions drasticactions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering TApp is already casted to be IApplication, I would agree that allowing UseMauiApp to use whatever supports it makes sense.

@rmarinho
Copy link
Member

/azp run MAUI-UITests-public

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rmarinho
Copy link
Member

/azp run MAUI-DeviceTests-public

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rmarinho rmarinho enabled auto-merge (squash) August 16, 2023 14:05
@mattleibow mattleibow added the backport/suggested The PR author or issue review has suggested that the change should be backported. label Aug 16, 2023
@rmarinho rmarinho merged commit 29a4bec into dotnet:main Aug 16, 2023
39 checks passed
@dansiegel dansiegel deleted the maui-embedding branch August 16, 2023 23:04
rmarinho pushed a commit that referenced this pull request Aug 19, 2023
@dansiegel @rmarinho
fix: MauiEmbedding extensions should use specified TApp type (#16758)
19f66c0
@hartez hartez added the backport/approved After some discussion or review, this PR or change was approved to be backported. label Aug 23, 2023
@hartez
Copy link
Contributor

hartez commented Aug 29, 2023

/backport to net7.0

@github-actions
Copy link
Contributor

Started backporting to net7.0: https://github.com/dotnet/maui/actions/runs/6017943756

@github-actions github-actions bot mentioned this pull request Aug 29, 2023
Merged
@davidbritch davidbritch mentioned this pull request Sep 26, 2023
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@drasticactions drasticactions drasticactions approved these changes

@mattleibow mattleibow mattleibow approved these changes

@rmarinho rmarinho rmarinho approved these changes

@jfversluis jfversluis Awaiting requested review from jfversluis jfversluis is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

@rachelkang rachelkang Awaiting requested review from rachelkang rachelkang is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

Assignees
No one assigned
Labels
backport/approved After some discussion or review, this PR or change was approved to be backported. backport/suggested The PR author or issue review has suggested that the change should be backported. community ✨ Community Contribution
Projects
None yet
Milestone
Under Consideration
Development

Successfully merging this pull request may close these issues.

UseMauiEmbedding extension does not use specified TApp
6 participants
@dansiegel @rmarinho @hartez @drasticactions @mattleibow @samhouts