Default paths for Appium projects, to simplify run steps #16763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems iOS tests are failing , but can't understand why . |
rmarinho
reviewed
Aug 16, 2023
|
/azp rebase |
|
Command 'rebase' is not supported by Azure Pipelines. Supported commands
See additional documentation. |
|
/rebase |
Default the paths for UITest projects so that the user doesn't need to specify them manually. Once this is merged I'll update the instructions in https://github.com/dotnet/maui/wiki/UITests to remove the --project and --appproject arguments from the run steps. That makes them much simpler and avoids the issue of them being hardcoded to Rui's home directory.
Also, improve error messages for windows/catalyst/ios similar to android, giving a user friendly error if the exe/app to be tested isn't found (likely because it's not built), instead of an NRE.
github-actions
bot
force-pushed
the
simplify-appium-launch-steps
branch
from
45bf7f0
to
47acfb1
Compare
rmarinho
approved these changes
Aug 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default the paths for UITest projects so that the user doesn't need to specify them manually. Once this is merged I'll update the instructions in https://github.com/dotnet/maui/wiki/UITests to remove the --project and --appproject arguments from the run steps. That makes them much simpler and avoids the issue of them being hardcoded to Rui's home directory.
Also, improve error messages for windows/catalyst/ios similar to android, giving a user friendly error if the exe/app to be tested
isn't found (likely because it's not built), instead of an NRE.