Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix using local asset files on windows #16930

Merged
merged 9 commits into from Dec 6, 2023
Merged

fix using local asset files on windows #16930

merged 9 commits into from Dec 6, 2023

Commits on Dec 4, 2023

  1. fix using UrlWebViewSource with a URL containing a LocalScheme URL on… 

    … windows that should trigger a call to CoreWebView2.SetVirtualHostNameToFolderMapping()
    @vividos @jfversluis
    vividos authored and jfversluis committed Dec 4, 2023
    Copy the full SHA
    57e0d2a View commit details
    Browse the repository at this point in the history

  2. fix using HtmlWebViewSource with a BaseUrl containing a LocalScheme U… 

    …RL on windows that should set up virtual host name to folder mapping correctly
    @vividos @jfversluis
    vividos authored and jfversluis committed Dec 4, 2023
    Copy the full SHA
    bf374c4 View commit details
    Browse the repository at this point in the history

  3. moved checking uri string with local scheme to own static method

    @vividos @jfversluis
    vividos authored and jfversluis committed Dec 4, 2023
    Copy the full SHA
    9c2291c View commit details
    Browse the repository at this point in the history

  4. moved checking data uri string to own static method

    @vividos @jfversluis
    vividos authored and jfversluis committed Dec 4, 2023
    Copy the full SHA
    dda39dc View commit details
    Browse the repository at this point in the history

  5. replaced ToLowerInvariant() call with StartsWith() parameter StringCo… 

    …mparison.OrdinalIgnoreCase
    @vividos @jfversluis
    vividos authored and jfversluis committed Dec 4, 2023
    Copy the full SHA
    ef25a1d View commit details
    Browse the repository at this point in the history

  6. added test buttons to platform specifics samples for Windows WebView … 

    …about loading local assets
    @vividos @jfversluis
    vividos authored and jfversluis committed Dec 4, 2023
    Copy the full SHA
    207e0ca View commit details
    Browse the repository at this point in the history

  7. changed sample HTML text to use raw string literals 

    Co-authored-by: MartyIX <203266+MartyIX@users.noreply.github.com>
    @vividos @MartyIX @jfversluis
    2 people authored and jfversluis committed Dec 4, 2023
    Copy the full SHA
    b51f2c8 View commit details
    Browse the repository at this point in the history

  8. put StartsWith() check on one line 

    Co-authored-by: MartyIX <203266+MartyIX@users.noreply.github.com>
    @vividos @MartyIX @jfversluis
    2 people authored and jfversluis committed Dec 4, 2023
    Copy the full SHA
    9e27557 View commit details
    Browse the repository at this point in the history

  9. removed flag _navigatingToHtmlWithBaseUrl and directly recognize WebV… 

    …iew2 data URI with inserted base tag
    @vividos @jfversluis
    vividos authored and jfversluis committed Dec 4, 2023
    Copy the full SHA
    79ec531 View commit details
    Browse the repository at this point in the history