[workload] Only install the WinUI pack on Windows #16937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building on macOS I've been hitting a workload install issue:
Workload installation failed. Rolling back installed packs...
Rolling back pack Microsoft.Maui.Graphics.Win2D.WinUI.Desktop installation...
Workload installation failed: microsoft.maui.graphics.win2d.winui.desktop::7.0.100-dev is not found in NuGet feeds ...
The project that produces this pack doesn't seem to be built on macOS,
and it's not available in the local artifacts feed after a build.
We can take advantage of [alias packs][0] to fix this issue. This will
also simplify workload installs for customers not on Windows, as the
pack will now be ignored entirely on other platforms.
[0]: https://github.com/dotnet/designs/blob/37718c66f403f7a5d25517cdac3ec2d2553100a6/accepted/2020/workloads/workload-manifest.md#alias-packs
pjcollins
added
the
area/setup 🪄
jonathanpeppers
approved these changes
Aug 22, 2023
There was a problem hiding this comment.
Ok, I see why this is needed:
dotnet workload install mauidepends onmaui-desktopdepends onmaui-windows
So, this means we effectively install maui-windows on all platforms: macOS, linux, etc.
You probably don't need Microsoft.Maui.Graphics.Win2D.WinUI.Desktop on macOS or linux. It's not possible to build a WindowsAppSDK app on those platforms.
mattleibow
approved these changes
Aug 22, 2023
|
Not sure why the test is failin now. |
rmarinho
approved these changes
Aug 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building on macOS I've been hitting a workload install issue:
The project that produces this pack doesn't seem to be built on macOS,
and it's not available in the local artifacts feed after a build.
We can take advantage of alias packs to fix this issue. This will
also simplify workload installs for customers not on Windows, as the
pack will now be ignored entirely on other platforms.