Fix so updating FlyoutItemIsVisible hides/shows shell menu item #16942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MenuShellItem wraps a MenuItem. Shell related properties should be synchronized between the two objects, always the same values. Add code so that FlyoutItemIsVisible is also synchronized. Most properties are synchroned via bindings, but FlyoutItemIsVisible is an attached property so we need to have code that runs on property changes instead. Fixes issue #16929 Note that normally the MenuItem is specified in XAML while MenuShellItem is accessed in code behind, thus the need to synchronize when FlyoutItemIsVisible is initialized in XAML then updated later via code behind, like in the bug.
PureWeen
approved these changes
Aug 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MenuShellItem wraps a MenuItem. Shell related properties should be synchronized between the two objects, always the same values. Add code so that FlyoutItemIsVisible is also synchronized. Most properties are synchroned via bindings, but FlyoutItemIsVisible is an attached property so we need to have code that runs on property changes instead.
Fixes issue #10468
Note that normally the MenuItem is specified in XAML while MenuShellItem is accessed in code behind, thus the need to synchronize when FlyoutItemIsVisible is initialized in XAML then updated later via code behind, like in the bug.