Use a fixed WinUI window size for Appium test app #16956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the screenshots more deterministic, more likely to match between dev machines and CI.
sbanni
reviewed
Aug 23, 2023
|
|
||
| protected override Window CreateWindow(IActivationState activationState) | ||
| { | ||
| #if WINDOWS |
There was a problem hiding this comment.
Won't we have the same problem on catalyst?
There was a problem hiding this comment.
Yes, good point. Updated.
There was a problem hiding this comment.
(And I updated this again, with the Catalyst sizing workaround code suggested by @mattleibow)
rmarinho
requested changes
Aug 24, 2023
There was a problem hiding this comment.
D:\a\_work\1\s\src\Controls\samples\Controls.Sample.UITests\MauiProgram.cs(56,14): error CS0219: The variable 'desktopWindowWidth' is assigned but its value is never used [D:\a\_work\1\s\src\Controls\samples\Controls.Sample.UITests\Controls.Sample.UITests.csproj::TargetFramework=net7.0-ios]
D:\a\_work\1\s\src\Controls\samples\Controls.Sample.UITests\MauiProgram.cs(57,14): error CS0219: The variable 'desktopWindowHeight' is assigned but its value is never used [D:\a\_work\1\s\src\Controls\samples\Controls.Sample.UITests\Controls.Sample.UITests.csproj::TargetFramework=net7.0-ios]
D:\a\_work\1\s\src\Controls\samples\Controls.Sample.UITests\MauiProgram.cs(56,14): error CS0219: The variable 'desktopWindowWidth' is assigned but its value is never used [D:\a\_work\1\s\src\Controls\samples\Controls.Sample.UITests\Controls.Sample.UITests.csproj::TargetFramework=net7.0-tizen]
D:\a\_work\1\s\src\Controls\samples\Controls.Sample.UITests\MauiProgram.cs(57,14): error CS0219: The variable 'desktopWindowHeight' is assigned but its value is never used [D:\a\_work\1\s\src\Controls\samples\Controls.Sample.UITests\Controls.Sample.UITests.csproj::TargetFramework=net7.0-tizen]
D:\a\_work\1\s\src\Controls\samples\Controls.Sample.UITests\MauiProgram.cs(56,14): error CS0219: The variable 'desktopWindowWidth' is assigned but its value is never used [D:\a\_work\1\s\src\Controls\samples\Controls.Sample.UITests\Controls.Sample.UITests.csproj::TargetFramework=net7.0-android]
D:\a\_work\1\s\src\Controls\samples\Controls.Sample.UITests\MauiProgram.cs(57,14): error CS0219: The variable 'desktopWindowHeight' is assigned but its value is never used [D:\a\_work\1\s\src\Controls\samples\Controls.Sample.UITests\Controls.Sample.UITests.csproj::TargetFramework=net7.0-android]
256 Warning(s)
6 Error(s)
fixed |
sbanni
previously approved these changes
Aug 24, 2023
mattleibow
previously approved these changes
Aug 25, 2023
rmarinho
approved these changes
Aug 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the screenshots more deterministic, more likely to match between dev machines and CI.
Previously the window size was the WinUI default, taking up maybe 2/3 of the screen width - so it
was huge on huge monitors, small on small monitors.