[android] CollectionView logical children grows with Header/Footer #17012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
reviewed
Aug 27, 2023
src/Controls/src/Core/Handlers/Items/Android/Adapters/StructuredItemsViewAdapter.cs
Outdated
Show resolved
Hide resolved
Fixes: dotnet#16961 Debugging the `ItemsSourceDoesNotLeak()` test with a new `Header` and `Footer` on Android, there was some very odd behavior... At the end of the test, `_logicalChildren` contained 9 items! Header Footer Header Footer Header null null null Footer Where I would expect it to contain 5?!? It appears the problem is: * `CollectionView.ItemsSource` changes * We notify Android's `RecyclerView` to refresh * `RecyclerView` calls `OnCreateViewHolder()` for the header, footer, and all rows. * `CreateHeaderFooterViewHolder()` is called again for the header & footer. * Duplicate `viewHolder.View` items are added as logical children. To fix this, an idea: * Create a new `internal ContainsLogicalChild()` method * Call this before adding the same `View` in `CreateHeaderFooterViewHolder()` This isn't the *best*, because it will iterate over the `_logicalChildren` to decide if the list contains the view. But this is better than what strange behavior might result from this?
jonathanpeppers
force-pushed
the
AndroidItemsSourceIsWeird
branch
from
f45758b
to
c35faf6
Compare
jonathanpeppers
force-pushed
the
AndroidItemsSourceIsWeird
branch
from
c35faf6
to
2ada004
Compare
PureWeen
approved these changes
Aug 28, 2023
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16961
Debugging the
ItemsSourceDoesNotLeak()test with a newHeaderandFooteron Android, there was some very odd behavior...At the end of the test,
_logicalChildrencontained 9 items!Where I would expect it to contain 5?!?
It appears the problem is:
CollectionView.ItemsSourcechangesWe notify Android's
RecyclerViewto refreshRecyclerViewcallsOnCreateViewHolder()for the header, footer, and all rows.CreateHeaderFooterViewHolder()is called again for the header & footer.Duplicate
viewHolder.Viewitems are added as logical children.To fix this, an idea:
Create a new
internal ContainsLogicalChild()methodCall this before adding the same
ViewinCreateHeaderFooterViewHolder()This isn't the best, because it will iterate over the
_logicalChildrento decide if the list contains the view. But this is better than what strange behavior might result from this?