[WinUI] Fix borders not showing bottom and right side #17016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seem to have regressed after the stroke thickness property values were fixed, making the path size bigger than the control itself and drawing the border outside of the bounds of the control. The main fix is on the path size, where we subtract the stroke thickness to the control size now, because it should not exceed the control size. And then the transformation was updated to make sure the content is correctly adapted. The transformation on the path is enough and we don't need to add another one on the content panel. Fixes #16667
PureWeen
requested review from
hartez,
mattleibow,
PureWeen and
jstedfast
and removed request for
jsuarezruiz and
rachelkang
rmarinho
requested review from
jsuarezruiz
and removed request for
mattleibow and
PureWeen
jstedfast
previously approved these changes
Aug 28, 2023
jstedfast
approved these changes
Aug 30, 2023
rmarinho
approved these changes
Aug 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This seem to have regressed after the stroke thickness property values were fixed, making the path size bigger than the control itself and drawing the border outside of the bounds of the control.
The main fix is on the path size, where we subtract the stroke thickness to the control size now, because it should not exceed the control size. And then the transformation was updated to make sure the content is correctly adapted. The transformation on the path is enough and we don't need to add another one on the content panel.
Issues Fixed
Fixes #16667