Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a public IList<IView> Children to new Layout base class #1722

Merged
merged 1 commit into from
Jul 20, 2021
Merged

Conversation

hartez
Copy link
Contributor

@hartez hartez commented Jul 16, 2021

Modifies the Layout class for the new layouts to expose a public IList<IView> Children { get; } for compatibility with XAML and the ContentProperty attribute.

The implementation of the IList interface runs all of the add/remove/insert/clear methods through the same bookkeeping previously used, so Parenting and layout invalidation are still happening.

We'll get an alternate discussion started on whether ILayout/IContainer still need to provide IReadOnlyList<IView> Children { get; }, or whether we can simply move to IContainer : IList<IView>.

@Redth Redth merged commit a05c0dd into main Jul 20, 2021
@Redth Redth deleted the fix-1682 branch July 20, 2021 20:09
@samhouts samhouts added the area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter label Jul 11, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants