Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Fix ScrollView filling layouts #17243

Merged
merged 14 commits into from
Oct 12, 2023
Merged

[Android] Fix ScrollView filling layouts #17243

merged 14 commits into from
Oct 12, 2023

Commits on Oct 9, 2023

  1. Tentative fix

    @jknaudt21
    jknaudt21 committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    94d2aff View commit details
    Browse the repository at this point in the history

  2. Address PR Feedback

    @jknaudt21
    jknaudt21 committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    63ef327 View commit details
    Browse the repository at this point in the history

  3. Clean up comment

    @jknaudt21
    jknaudt21 committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    0ec8beb View commit details
    Browse the repository at this point in the history

  4. Make tests print clear output

    @jknaudt21
    jknaudt21 committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    4cb6410 View commit details
    Browse the repository at this point in the history

  5. Reduce device test strictness

    @jknaudt21
    jknaudt21 committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    6914c48 View commit details
    Browse the repository at this point in the history

  6. Update ScrollViewTests.cs

    @jknaudt21
    jknaudt21 committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    5e07985 View commit details
    Browse the repository at this point in the history

  7. Add more logging to test, ensure no margin

    @jknaudt21
    jknaudt21 committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    602d287 View commit details
    Browse the repository at this point in the history

  8. Add tolerance

    @jknaudt21
    jknaudt21 committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    e596918 View commit details
    Browse the repository at this point in the history

  9. Use tolerance

    @jknaudt21
    jknaudt21 committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    1069540 View commit details
    Browse the repository at this point in the history

  10. Greatly reduce expected height, remove margin & padding

    @jknaudt21
    jknaudt21 committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    7e87c57 View commit details
    Browse the repository at this point in the history

  11. Throw Screenshot to see error

    @jknaudt21
    jknaudt21 committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    b156ef6 View commit details
    Browse the repository at this point in the history

  12. Add colors

    @jknaudt21
    jknaudt21 committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    44d2bce View commit details
    Browse the repository at this point in the history

  13. Update tests so they skip mac until issue is fixed

    @jknaudt21
    jknaudt21 committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    2b48f37 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2023

  1. Fix Windows tests!

    @jknaudt21
    jknaudt21 committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    e72f010 View commit details
    Browse the repository at this point in the history