Remove null forgiveness operator and fix NRE from PlatformView in disconnect
#17248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
commented
Sep 7, 2023
| } | ||
|
|
||
| protected override void DisconnectHandler(FrameworkElement platformView) | ||
| { | ||
| base.DisconnectHandler(platformView); | ||
|
|
||
| ShellItemNavigationView.SelectionChanged -= OnNavigationTabChanged; | ||
| if (platformView is MauiNavigationView mnv) | ||
| mnv.SelectionChanged -= OnNavigationTabChanged; |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
In the disconnect part of the
ShellItemHandlerwe were referring to the wrong platformview. This was further enabled by the use of a null forgiveness operator. I've removed the null forgiveness code, so that each use needs to be account for a possible null platformview.