Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XamlC] fix generic array #17301

Merged
merged 2 commits into from Sep 26, 2023
Merged

[XamlC] fix generic array #17301

merged 2 commits into from Sep 26, 2023

Conversation

StephaneDelcroix
Copy link
Contributor

Description of Change

fix generic resolution for interfaces with generic array types.

Issues Fixed

@StephaneDelcroix StephaneDelcroix requested a review from a team as a code owner September 11, 2023 12:42
@Eilon Eilon added the area/Xaml </> Controls - XAML, CSS, Gestures, Triggers, Behaviors label Sep 11, 2023
@samhouts samhouts added this to the Under Consideration milestone Sep 11, 2023
@samhouts samhouts added the stale Indicates a stale issue/pr and will be closed soon label Sep 19, 2023
@samhouts
Copy link
Member

failing checks

@samhouts samhouts added the s/pr-needs-author-input PR needs an update from the author label Sep 19, 2023
@ghost
Copy link

ghost commented Sep 19, 2023

Hi @StephaneDelcroix. We have added the "s/pr-needs-author-input" label to this issue, which indicates that we have an open question/action for you before we can take further action. This PRwill be closed automatically in 14 days if we do not hear back from you by then - please feel free to re-open it if you come back to this PR after that time.

fix generic resolution for interfaces with generic array types.

- fix #10583
@ghost ghost removed stale Indicates a stale issue/pr and will be closed soon s/pr-needs-author-input PR needs an update from the author labels Sep 21, 2023
@StephaneDelcroix
Copy link
Contributor Author

failing tests are irrelevant to the PR, but the last commit should fix them

@StephaneDelcroix
Copy link
Contributor Author

failing checks

@samhouts fixed

@PureWeen PureWeen merged commit c953ffb into main Sep 26, 2023
45 checks passed
@PureWeen PureWeen deleted the fix_10583 branch September 26, 2023 14:49
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/Xaml </> Controls - XAML, CSS, Gestures, Triggers, Behaviors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Xaml Compiler NullRef with Grid.Resources
4 participants