Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split out sharable testing for non-element thing #17387

Merged
merged 1 commit into from Sep 20, 2023
Merged

Conversation

mattleibow
Copy link
Member

Description of Change

This PR extracts the core idea of a "gallery" and makes it usable for non-one-element tests. I will be adding some input transparency tests and I can leverage this a fair bit.

An example usgae:

internal class InputTransparencyGalleryPage : CoreGalleryBasePage
{
    protected override void Build()
    {
        Add(Test.Thing1, new ViewContainer(<test here>));
        Add(Test.Thing2, new ViewContainer(<test here>));
    }
}
public class InputTransparencyGalleryTests : CoreGalleryBasePageTest
{
    const string ButtonGallery = "* marked:'Input Transparency Gallery'";

    public InputTransparencyGalleryTests(TestDevice device)
        : base(device)
    {
    }

    protected override void NavigateToGallery() =>
        App.NavigateToGallery(ButtonGallery);

    [Test]
    public void Thing1()
    {
        // ui test code
    }
    [Test]
    public void Thing2()
    {
        // ui test code
    }
}

@mattleibow mattleibow requested a review from a team as a code owner September 14, 2023 22:44
@mattleibow mattleibow closed this Sep 14, 2023
@mattleibow mattleibow reopened this Sep 14, 2023
@PureWeen PureWeen requested review from sbanni and removed request for StephaneDelcroix September 15, 2023 01:05
@mattleibow
Copy link
Member Author

/rebase

@mattleibow
Copy link
Member Author

UI tests failures are unrelated and are also failing on main:

image

This PR extracts the core idea of a "gallery" and makes it usable for non-one-element tests. I will be adding some input transparency tests and I can leverage this a fair bit.
@mattleibow
Copy link
Member Author

All fixed!!!

@PureWeen PureWeen merged commit 63be80c into main Sep 20, 2023
45 checks passed
@PureWeen PureWeen deleted the dev/testing-stuff branch September 20, 2023 22:15
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants