[Android] Fix ReturnType on Entry #17546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
added
t/bug
ghost
added
the
area/controls 🎮
PureWeen
removed
the
backport/suggested
rmarinho
approved these changes
Sep 27, 2023
jknaudt21
reviewed
Sep 27, 2023
| @@ -41,6 +41,7 @@ public override void SetVirtualView(IView view) | |||
| // TODO: NET8 issoto - Change the return type to MauiAppCompatEditText | |||
| protected override void ConnectHandler(AppCompatEditText platformView) | |||
| { | |||
| platformView.ViewAttachedToWindow += OnViewAttachedToWindow; | |||
There was a problem hiding this comment.
Curious to hear why set the return type on this event instead of the constructor?
There was a problem hiding this comment.
I think is just normal practice also if it gets reused you know the value is updated when being added
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix ReturnType on Android Entry.
Issues Fixed
Fixes #17463
NOTE: It's marked as a regression from NET 7 but I can reproduce it in NET 8 as well. So I would add it to main and then backport it.