Wrap Image with a container on Windows so that it is centered with AspectFill #17665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emaf
previously approved these changes
Oct 6, 2023
hartez
suggested changes
Oct 6, 2023
PureWeen
reviewed
Oct 9, 2023
|
/rebase |
PureWeen
force-pushed
the
dev/japarson/10645
branch
from
a14676e
to
cf1b0aa
Compare
samhouts
added
platform/windows 🪟
and removed
stale
|
For now let's just merge this without the updated extensions. |
|
/rebase |
|
@japarson Could you please resolve conflicts and add a UI test? Thanks! |
japarson
force-pushed
the
dev/japarson/10645
branch
from
cf1b0aa
to
4bcd85b
Compare
|
/rebase |
github-actions
bot
force-pushed
the
dev/japarson/10645
branch
from
c5068cb
to
d6f40dd
Compare
Eilon
added
area-controls-image
jsuarezruiz
reviewed
May 13, 2024
There was a problem hiding this comment.
With the changes in the UI Test runner, we need to regenerate the snapshot (now navigates directly to the issue page, and the NavigationBar will no be rendered).
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
On Windows, we use Microsoft.UI.Xaml.Controls.Image which has a stretch property. When this property is set in WinUI, the image will not be centered. According to the WinUI team, this is intended behavior:
As you can see in the screenshot above, one workaround we can utilize is to wrap the image in a
Grid. Luckily, we can utilize the existing WrapperView on Windows by adding aContainerViewto the WindowsImageHandler.Before
After
Issues Fixed
Fixes #10645
Copied from #15122
Depends on