Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows] Implement gestures on Spans #17731

Merged
merged 1 commit into from Feb 21, 2024
Merged

[Windows] Implement gestures on Spans #17731

merged 1 commit into from Feb 21, 2024

Conversation

jsuarezruiz
Copy link
Contributor

@jsuarezruiz jsuarezruiz commented Sep 29, 2023 •
edited by mattleibow

Description of Change

Implement gestures on Windows Spans.

Issues Fixed

@jsuarezruiz jsuarezruiz added t/bug Something isn't working platform/windows 🪟 control-label Label, Span labels Sep 29, 2023
@ghost ghost added the area/controls 🎮 Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Sep 29, 2023
@samhouts
Copy link
Member

samhouts commented Oct 5, 2023

failing checks

@samhouts samhouts added the s/pr-needs-author-input PR needs an update from the author label Oct 5, 2023
@ghost
Copy link

ghost commented Oct 5, 2023

Hi @jsuarezruiz. We have added the "s/pr-needs-author-input" label to this issue, which indicates that we have an open question/action for you before we can take further action. This PRwill be closed automatically in 14 days if we do not hear back from you by then - please feel free to re-open it if you come back to this PR after that time.

@samhouts samhouts modified the milestones: .NET 8 SR1, .NET 8 SR2 Oct 9, 2023
@ghost
Copy link

ghost commented Oct 28, 2023

Hi @jsuarezruiz.
It seems you haven't touched this PR for the last two weeks. To avoid accumulating old PRs, we're marking it as stale. As a result, it will be closed if no further activity occurs within 4 days of this comment. You can learn more about our Issue Management Policies here.

@ghost ghost added the stale Indicates a stale issue/pr and will be closed soon label Oct 28, 2023
@ghost ghost closed this Nov 1, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2023
@mattleibow mattleibow reopened this Feb 15, 2024
@mattleibow mattleibow modified the milestones: .NET 8 SR2, .NET 8 SR3 Feb 15, 2024
@mattleibow mattleibow force-pushed the fix-4734-windows branch 2 times, most recently from 2f1255b to bc0e0aa Compare February 15, 2024 16:54
@mattleibow mattleibow marked this pull request as ready for review February 15, 2024 16:59
@mattleibow mattleibow requested a review from a team as a code owner February 15, 2024 16:59
@mattleibow mattleibow force-pushed the fix-4734-windows branch 2 times, most recently from 03d46ba to 02973eb Compare February 15, 2024 19:17
@mattleibow
Copy link
Member

Rebased and did some tests, seems to work locally.

@ghost ghost closed this Feb 19, 2024
@mattleibow mattleibow removed the stale Indicates a stale issue/pr and will be closed soon label Feb 20, 2024
@mattleibow mattleibow reopened this Feb 20, 2024
@mattleibow
Copy link
Member

/rebase

@PureWeen PureWeen merged commit 813c7c9 into main Feb 21, 2024
47 checks passed
@PureWeen PureWeen deleted the fix-4734-windows branch February 21, 2024 23:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattleibow mattleibow mattleibow approved these changes

@PureWeen PureWeen PureWeen approved these changes

@jfversluis jfversluis Awaiting requested review from jfversluis jfversluis is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

@tj-devel709 tj-devel709 Awaiting requested review from tj-devel709 tj-devel709 is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

Assignees
No one assigned
Labels
area/controls 🎮 Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor control-label Label, Span platform/windows 🪟 s/pr-needs-author-input PR needs an update from the author t/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gestures don't work on Label Spans
4 participants
@jsuarezruiz @samhouts @mattleibow @PureWeen