Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Doc improvements to fix online browser warnings #17732

Merged
merged 12 commits into from Oct 11, 2023
Merged

Conversation

jfversluis
Copy link
Member

@jfversluis jfversluis commented Sep 29, 2023

Description of Change

Removes unnecessary <inheritdoc/> tags that don't refer to actual comments. Unfortunately in VS this does not give you any warnings, but the build system to publish the online API docs is issuing warnings on these cases.

This change also includes some housekeeping to account for dotnet/dotnet-maui-api-docs#6 and dotnet/dotnet-maui-api-docs#5

Issues Fixed

Fixes dotnet/dotnet-maui-api-docs#5
Fixes dotnet/dotnet-maui-api-docs#6

@jfversluis jfversluis added area-docs Conceptual docs, API docs, Samples t/housekeeping ♻︎ labels Sep 29, 2023
@samhouts samhouts added this to the .NET 8 GA milestone Oct 9, 2023
@jfversluis jfversluis marked this pull request as ready for review October 11, 2023 11:18
@jfversluis jfversluis requested a review from a team as a code owner October 11, 2023 11:18
@jfversluis jfversluis merged commit c4752f6 into main Oct 11, 2023
47 checks passed
@jfversluis jfversluis deleted the fix-net8-apidocs branch October 11, 2023 11:18
@PureWeen
Copy link
Member

/backport to release/8.0.1xx-rc2.2

@github-actions
Copy link
Contributor

Started backporting to release/8.0.1xx-rc2.2: https://github.com/dotnet/maui/actions/runs/6631842190

rachelkang pushed a commit that referenced this pull request Oct 25, 2023
* Update View.cs

* Update Element.cs

* More fixes

* Update Page.cs

* Remove dead links

* More fixes

* Remove developer.xamarin.com references public doc

* Remove developer.xamarin.com refs from comments

* Remove xamarin-forms references mostly

* Update VisualElement.xml

* Remove unused XML doc files

* OK maybe not VisualElement
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-docs Conceptual docs, API docs, Samples t/housekeeping ♻︎
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doc cleanup: Links to developer.xamarin.com Doc cleanup: Links to Xamarin.Forms conceptual docs
4 participants