Make sure to account for a null AppWindow #17746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattleibow
previously approved these changes
Sep 29, 2023
jsuarezruiz
approved these changes
Oct 2, 2023
Foda
approved these changes
Oct 2, 2023
|
/backport to release/8.0.1xx-rc2.2 |
|
Started backporting to release/8.0.1xx-rc2.2: https://github.com/dotnet/maui/actions/runs/6631908834 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
When opening a new WinUI window. If the user parents that to the current window
UI.Xaml.Window.AppWindowwill be null so we need to account for this.I've also added
Window.AppWindowto our set of banned APIs since it doesn't have null safety. OurGetAppWindowAPI does so that should keep us in a safer place to not regress this issue.Issues Fixed
Fixes #17490